Hi Julian, On reviewing the State::DefineMap::updateCurrentDefines() method change of yours that I merged I decided to remove the if(changed) else as an if(changed) is done in the calling code already so was a redundant check. I have checked in removal if ().
Robert. On 29 June 2016 at 16:06, Robert Osfield <[email protected]> wrote: > Hi Julian, > > This change looks appropriate. Now merged with osg master. > > Thanks, > Robert. > > On 29 June 2016 at 16:05, Julien Valentin <[email protected]> wrote: >> Hi Robert >> Okay here's a fix that seams reasonnable to me: >> in bool State::DefineMap::updateCurrentDefines() (State.cpp l1827) >> the changed flag is not resetted (anywhere) to false after currentDefines is >> updated >> https://github.com/mp3butcher/OpenSceneGraph/commit/b70ebf77c00b68c3859d71504219029dfcacaa20 >> I attached the modified State.cpp >> >> Sorry for the previous noisy/fuzzy posts >> >> >> mp3butcher wrote: >>> I understand, >>> Will try to figure it out by myself >>> >>> >>> robertosfield wrote: >>> > Hi Julian, >>> > >>> > On 29 June 2016 at 14:40, Julien Valentin <> wrote: >>> > >>> > > Perhaps your knowledge could enlighten me on the purpose of this test.. >>> > > >>> > >>> > Sorry but I'm already overwhelmed with many different tasks to do and >>> > things to understand right now. If something is genuinely broken >>> > please create a test case that I can reproduce myself, otherwise I >>> > really don't want to waste time on stuff that doesn't appear to be >>> > broken so is just yet another distraction for all the other stuff I >>> > need to get done. >>> > >>> > Robert. >>> > _______________________________________________ >>> > osg-submissions mailing list >>> > >>> > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >>> > >>> > ------------------ >>> > Post generated by Mail2Forum >>> >> >> >> ------------------ >> Read this topic online here: >> http://forum.openscenegraph.org/viewtopic.php?p=67913#67913 >> >> >> >> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
