Hi Julien, I have just merged your serialize support for RigTransforms. I don't merge all the changes as is though, rather opting for a minimal set of changes, functionality is the same though. One of the changes I didn't merge was the addition of the osg::Node to the associates list of RigGeometry serialize as this would break backwards compatibiliyt. Actually just realized that we need to add a version around the RigTransformImplementation. I'll add the later right now.
Robert. On 27 June 2016 at 14:55, Julien Valentin <[email protected]> wrote: > I removed temp gedit from archive and also take care of the new coverity > warning about RigTransorms copy constructors > > > mp3butcher wrote: >> Sorry for the gedit temporary files in the zip:/ >> >> >> mp3butcher wrote: >> > Hi Robert >> > I forgot RigTransform serializers files in my last zip >> > I also had to add a const getter in RigGeometry so i attached it too. >> > >> > Julien. >> > >> > >> > robertosfield wrote: >> > > Thanks Julian, merged the changes with a few tweaks for spacing and >> > > warnings. >> > > >> > > On 27 June 2016 at 11:27, Julien Valentin <> wrote: >> > > >> > > > Here's a zip containing: >> > > > -Rolbacked RigGeometry with the hackyfix (I just add the compute >> > > > boundcallback in the copy consturctor) >> > > > -Modified headers of RigTransforms to comply with osg metamodel >> > > > >> > > > >> > > > robertosfield wrote: >> > > > >> > > > > HI Julien, >> > > > > >> > > > > On 26 June 2016 at 23:14, Julien Valentin <> wrote: >> > > > > >> > > > > >> > > > > > Hi Robert, >> > > > > > I've made an other pull request without the hacky fix >> > > > > > https://github.com/cedricpinson/osg/pull/68 >> > > > > > and close the other >> > > > > > >> > > > > > >> > > > > >> > > > > Do I need to apply another on the osg master side w.r.t "hacky fix"? >> > > > > >> > > > > Robert. >> > > > > _______________________________________________ >> > > > > osg-submissions mailing list >> > > > > >> > > > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> > > > > >> > > > > ------------------ >> > > > > Post generated by Mail2Forum >> > > > > >> > > > >> > > > >> > > > ------------------ >> > > > Read this topic online here: >> > > > http://forum.openscenegraph.org/viewtopic.php?p=67851#67851 >> > > > >> > > > >> > > > >> > > > >> > > > _______________________________________________ >> > > > osg-submissions mailing list >> > > > >> > > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> > > > >> > > > >> > > _______________________________________________ >> > > osg-submissions mailing list >> > > >> > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> > > >> > > ------------------ >> > > Post generated by Mail2Forum >> > >> > > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=67857#67857 > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
