Hi Torben, I feel that VS specific mechanisms should be wrapped up into more cross platform ones where possible so the bulk of the Find script isn't related to VS specific CMake variable, instead having these platform specific Cmake variables localized. I.e. what the COLLADA_BUILDNAME has been doing just fine for years.
Robert. On 5 April 2017 at 08:36, Torben Dannhauer <[email protected]> wrote: > Hm ok, what is your suggested way to decouple the platform toolset from the > MSVC version in the CMake files? This is relatively new in VS and it will > take some time until all CMake projects adapt it and use a different approach > than the current MSVC version... > Since collada seems to be unmaintained, I double there will be any adaption.. > > One solution would be to guard it, something like this: > > IF(APPLE) > SET(COLLADA_BUILDNAME "mac") > ELSEIF(MINGW) > SET(COLLADA_BUILDNAME "mingw") > ELSEIF(MSVC14) > SET(COLLADA_BUILDNAME "vc14") > ELSEIF(MSVC12) > SET(COLLADA_BUILDNAME "vc12") > ELSEIF(MSVC11) > SET(COLLADA_BUILDNAME "vc11") > ELSEIF(MSVC10) > SET(COLLADA_BUILDNAME "vc10") > ELSEIF(MSVC90) > SET(COLLADA_BUILDNAME "vc9") > ELSEIF(MSVC80) > SET(COLLADA_BUILDNAME "vc8") > ELSE(APPLE) > SET(COLLADA_BUILDNAME "linux") > ENDIF(APPLE) > > IF (CMAKE_VS_PLATFORM_TOOLSET) > string(REPLACE "v" "vc" CMAKE_VS_PLATFORM_TOOLSET_VC_PREFIXED > ${CMAKE_VS_PLATFORM_TOOLSET}) > ELSE > set(CMAKE_VS_PLATFORM_TOOLSET_VC_PREFIXED $( COLLADA_BUILDNAME)) > ENDIF > > Torben > > > -----Ursprüngliche Nachricht----- > Von: osg-submissions > [mailto:[email protected]] Im Auftrag von > Robert Osfield > Gesendet: Mittwoch, 5. April 2017 09:29 > An: OpenSceneGraph Submissions <[email protected]> > Betreff: Re: [osg-submissions] Update to FindCollada.cmake > > HI Torben, > > I just added a : > > MESSAGE("CMAKE_VS_PLATFORM_TOOLSET = " ${CMAKE_VS_PLATFORM_TOOLSET}) > > And it's blank. My guess is it's not defined - I'm under Linux so I can't > imagine a VS specific CMake variable being relevant. > > Robert. > > > > > On 5 April 2017 at 08:20, Torben Dannhauer <[email protected]> wrote: >> Indeed, time is running fast. :)) >> >> Regarding CMake: >> >> Strange, the relevant line is this: >> >> string(REPLACE "v" "vc" CMAKE_VS_PLATFORM_TOOLSET_VC_PREFIXED >> ${CMAKE_VS_PLATFORM_TOOLSET}) >> >> For me it seems that REPLACE has exactly 4 arguments. What is your >> content of ${CMAKE_VS_PLATFORM_TOOLSET} ? >> >> Torben >> >> -----Ursprüngliche Nachricht----- >> Von: osg-submissions >> [mailto:[email protected]] Im Auftrag >> von Robert Osfield >> Gesendet: Mittwoch, 5. April 2017 09:03 >> An: OpenSceneGraph Submissions >> <[email protected]> >> Betreff: Re: [osg-submissions] Update to FindCollada.cmake >> >> HI Torben, >> >> On 5 April 2017 at 07:55, Torben Dannhauer <[email protected]> wrote: >>> Hi Robert, thanks for the feedback! Can you try the current Cmake release? >> >> I don't have a particular old version of cmake - using the one that >> came with Kubuntu 16.04., Forcing users to use recent cmake releases >> will affect lots of users so it's not something I'm willing to do this >> close to new stable release. If we do require a big step up in cmake >> version then it'd need to be some very significant functionality. >> >>> I'll look into it as soon as my daughter sleeps (~30min). >> >> Ahhh that takes me back, way back :-) >> >> My three daughters put themselves to bed now, one typically after I go >> to bed - she's 18 in a couple months, jikes I must be getting old... >> >> Cheers, >> Robert. >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph. >> org >> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscene >> graph.org > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
