Hi, Robert!

Thank you!!!


*PS*
Next time, I'll (create) pull requests on github
<https://github.com/openscenegraph/OpenSceneGraph>.



2017-05-26 10:24 GMT+03:00 Konstantin <[email protected]>:

>
> 25 мая 2017 г. 12:46 PM пользователь "Robert Osfield" <
> [email protected]> написал:
>
> Hi Konstantin,
>>
>> gmail is allowing me to download you attachment now so I've been able
>> to to do a review of the changes.  I understand the motivation behind
>> the changes but feel that they are too intrusive in the they way they
>> push platform specific issues across the code.
>>
>> I have amended the code to use DrawElements in the Text header, and
>> DrawElementsUShort in the .cpp to make it more flexible and compatible
>> with GLES2 implementations that don't support uint.
>>
>>     https://github.com/openscenegraph/OpenSceneGraph/commit/8b43
>> 3f8364a02bb07f57e96c6de9abbc2d42adce
>>
>>
>> Robert.
>>
>> On 12 May 2017 at 11:31, Robert Osfield <[email protected]> wrote:
>> > On 5 April 2017 at 14:58, Konstantin <[email protected]> wrote:
>> >> Is submissions still working or should I use Pull requests on github?
>> >
>> > My mail client is blocking your attachment suggestion there could be a
>> > virus issue with it.  Could you generate a PR for the change?
>> >
>> > Thanks,
>> > Robert.
>> _______________________________________________
>> osg-submissions mailing list
>> [email protected]
>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions
>> -openscenegraph.org
>>
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to