Hi Robert,
Thanks, I appreciate the alternative implementation and agree that my
solution was a bit more awkward. I tested your version with my test code
as well and it works fine!
Regards,
Andreas
On 2017-11-11 12:29, Robert Osfield wrote:
Hi Andreas,
I did a review of your changes and feel that the changes make the code
a bit awkward to read so having learned what is wrong with the
original code from you submission have refactored rawImageRec so it's
back to it's original simple unref counted status without any virtual
functions, and moved the ref counting into a separate refImageRec
class that subclasses from rawImageRec and Referenced. I also
introduced use of a & reference rather than use of C* pointer so that
the various refImageRec access codes can use . instead of ->, this
helps with the readability of the code. The changes are in the
commit:
https://github.com/openscenegraph/OpenSceneGraph/commit/ee118c872f1d4fa0ad2ab7a0b96bf2279bc3d925
To test of the write .rgb bug in the original code I created the
attached small test program, this confirm that the original write code
was buggy and when your or my new changes are applied the .rgb is now
output correctly. I attach my test program for completeness.
Cheers,
Robert.
On 10 November 2017 at 16:30, Andreas Ekstrand
<[email protected]> wrote:
Hi,
Attached is a fix in ReaderWriterRGB, based on latest from Git, that
encapsulates the true raw image data in a separate struct.
After the change from 2016 that made rawImageRec extend osg::Referenced and
implement a constructor/destructor, it wasn't really 'raw' and didn't work
when writing .rgb files - unwanted header data was written.
Regards,
Andreas
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
