Hi Raymond.
I'm just doing a review, one little change I'm a bit surprised by is the
following addition to OpenSceneGraph/src/osgPlugins/exr/CMakeLists.txt:
INCLUDE_DIRECTORIES( ${ILMBASE_INCLUDE_DIR}/OpenEXR )
I get idea that you need to provide another include for a separate ilmbase
include, but surprised bu the OpenEXR suffix. I'm not yet familiar with
ilmbase headers, is that they contain OpenEXR subdirectories?
Thanks for any clarification,
Robert.
On 14 November 2017 at 06:54, Raymond de Vries | Orphiction BV <
[email protected]> wrote:
> Hi Robert,
>
> Please find attached fixes for configuring and building the osgPlugin exr
> with Visual Studio and using out-of-the-box builds of ilmbase and openexr,
> i.e. without manual/extra config for using these 2 libs with the OSG.
>
> Previously, the assumption was made that ilmbase and openexr were
> installed in a common directory and hence the header files and libs were
> both found in that common directory. That is not consistent with other libs
> and this submission makes it consistent and therefore the OSG configures
> out of the box. I made this work for ilmbase-2.1.0.tar.gz /
> openexr-2.1.0.tar.gz and ilmbase-2.2.0.tar.gz / openexr-2.2.0.tar.gz
>
> Btw1 Findilmbase.cmake is new
> Btw2 I tested only with Visual Studio and I guess you can quickly test it
> on Linux ;-)
>
> Cheers, thanks,
> Raymond
>
>
> --
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
