Hi Frank, Change look good, now merged with OSG master the the 3.6 branch. For submissions github based PR's a little more convenient, but either way works fine for me.
Cheers, Robert. On 3 April 2018 at 19:53, Frank Bausch, Code 5773 <[email protected]> wrote: > Hi! > > > > I’ve been working on testing conversions from ECEF to LLA, as implemented by > EllipsoidModel::convertXYZToLatLongHeight in > ./include/osg/CoordinateSystemNode. > > > > When testing XYZ/ECEF coordinate values that convert to LLA points with > latitude = 90.0 or latitude = -90.0, the heights calculated by > EllipsoidModel::convertXYZToLatLongHeight have substantial errors. With the > provided change, points at the pole are handled more correctly. This has > been tested against US NGA GoldData. > > > > Attached is a patched version of the file from master, though the code in > question appears unchanged as far back as 3.4.1. > > > > I’m attempting to follow closely your submission guidelines. If you’d prefer > a PR, I’d be happy to submit one. > > > > Thanks, > > Frank > > > > > > > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
