Hi Farshid, I've done a first pass review and don't feel comfortable with adding a series of images on the back of one. This trick is something you will be aware of as the author but I can't imagine many other users being able to spot that it's even supported let alone how to use it.
I think the correct approach would be to return back a container for all of the images. Ideally osg::ImageList would be a full osg::Object so we'd be able to have a ReaderWriterDDS::readObject() method that could return an object containing all the images. Perhaps have an osg::Images object that subclasses from osg::Object and ImageList. Thoughts? Robert. On 9 May 2018 at 18:56, Farshid Lashkari <[email protected]> wrote: > Hi Robert, > > I've added an option to the DDS plugin to support loading all cubemap > images. The loader accepts an optional data parameter "dds_image_list" that > is a pointer to an osg::ImageList. When this is specified and the DDS file > contains multiple cubemap images, the loader will add the additional images > to the list. This can also be used in the future if someone decides to add > 2d image array support to the dds plugin. > > I also added some meta data to the main image that specifies how many images > are in the file and whether it is a cubemap. I also set the default origin > to TOP_LEFT. It was previously setting the origin to BOTTOM_LEFT only if the > flip option was set, but not to TOP_LEFT when the option was not present. I > believe this should now be the correct behavior. > > Cheers, > Farshid > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
