Hi Robert, My change was based on the latest master version from github at the time of submission. Looks like there have been some changes since then. I can submit a PR through github based on the current version. Do you prefer to have submissions made through github now?
Cheers, Farshid On Tue, Oct 2, 2018 at 4:38 AM Robert Osfield <[email protected]> wrote: > Hi Farshid, > > I'm just reviewing this submission. Which version of the OSG did you > base them on? Texture.cpp has had various changes so it's hard to see > what changes you've made and what are from other changes. > > Creating a PR via github is a decent alternative to posting > osg-submissions as it's a bit clearer what the base of the work was. > > Cheers, > Robert. > On Wed, 18 Jul 2018 at 16:46, Farshid Lashkari <[email protected]> wrote: > > > > Hi Robert, > > > > I was getting a black image when enabling hardware mipmap generation on > cubemaps. I believe the problem is that the base Texture class is hard > coding GL_TEXTURE_2D when enabling mipmap generation, instead of using the > target type from the derived class. I've attached the small change that > fixed the issue for me. > > > > Cheers, > > Farshid > > _______________________________________________ > > osg-submissions mailing list > > [email protected] > > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
