Hi Adrian, I have just done a quick review of your changes, and they are indeed these intrusive, but I'm a bit uncomfortable about the use the Singleton, if we are to go this approach then it would be better to push the provision of the various factories to the classes that they are producing.
Your original concept of providing a Configuration object to the Viewer classes is actually quite a powerful one, as it could be extended to encompass the configuration of not just things like which DatabasePager to user, but also the window and camera configuration. Perhaps a mixture of factory and configuration classes/objects would be best. Robert. On 7/31/07, Adrian Egli <[EMAIL PROTECTED]> wrote: > After doing the 2nd review of the Configure class, i redesigned it. Further > i remarked that we should > have a similar configuration object for each packages, or at least for the > osgUtil packages. For example > you creates a new SceneView objects with CullVisitor and UpdateVisitor > inside. May it would be > better to create the core objects like CullVisitor, UpdateVisitor,... by > using a factory. So we would > have to biggest flexibilty of the creation for the objects. But i just need > my own database pager > to boost my paging. My we can handle by user accessing and casting the > SceneView object by the latest > interface you added last week. i don't know what would be the easiest way to > solve this issue. > > i the attachment i have the changes i did. (tag: //adegli) > > //adegli setDatabasePager(new osgDB::DatabasePager); > setDatabasePager(osgViewer::Configuration::instance()->getDatabasePagerFactory()->produceDatabasePager());//adegli > > > this code works for my application, and this design is now much easier. > > > /Adegli > > 2007/7/28, Robert Osfield <[EMAIL PROTECTED]>: > > > > Hi Adrian, > > > > On 7/24/07, Adrian Egli <[EMAIL PROTECTED]> wrote: > > > perfect, i propse to do a review myself, may you will be able to send > just > > > the files, then i can review them for a third review :-) > > > > Have you done a review? I'm now ready to do a second review with a > > view to getting changes integrated for the next dev release, just > > point me at the source code you want me to consider. > > > > BTW, I've now added a s/getRenderer(Object*) method into osg::Camera > > that I plan to use to attach the GraphicsOperations to that are doing > > the rendering, this way you'll be able to do a dynamic_cast<> to get > > the implementation, and from this the SceneView being used. One will > > also be able to set your own renderer that can be passed on to the > > GraphicsThreads to use for rendering. > > > > The above isn't wired up yet. You Configuration class should be able > > to dovtail in with these changes though. Right now don't worry about > > this, rather just get your Configuration working for your own purposes > > then I can adapt if required at my end. > > > > Cheers, > > Robert. > > _______________________________________________ > > osg-users mailing list > > [email protected] > > > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > > > > > -- > ******************************************** > Adrian Egli > _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
