Hi all, In PixelDataBufferObject::bindBufferInWriteMode() I was surprised to see glBindBuffer(GL_PIXEL_PACK_BUFFER_ARB,...). According to the OpenGL spec "Pack" refers to *reading* pixels from the GPU into main memory. Is this a bug? The comment for the function explicitly says "note: GL_PIXEL_PACK_BUFFER_ARB" so I'm guessing it's intentional, and maybe in some particular situation it makes sense. However in the general case the naming is incorrect and has in fact lead me to call the wrong function.
If this isn't a bug then to prevent others being similarly mislead I suggest we do one of the following: a) Rename the functions to bindBufferInPackMode/bindBufferInUnpackMode b) Just have one bindBuffer function that takes the target as a parameter. c) Just have one bindBuffer function that uses the target returned by BufferObject::getTarget() Cheers -Michael
_______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
