Hi John, Thanks for the clarification and warning output.
I've added a newline to the end of GraphicsCostEstimator. I can only guess that recent versions of gcc don't have problems with the lack of newline. Your gcc seems rather out of date by comparison to what I've been using for a while, this shouldn't cause major problems though, the more recent compilers tend to be stricter and compile less code rather than more, so typically if compiles under gcc 4.5.1 it'll compile in older versions as well. I have also added a virtual destructor to View::Slave. The DCMTK build issue looks to me like a missing ) from a line in the USE_ITK block in the ReaderWriterDICOM.cpp. I haven't tested the ITK path recently so this is probably why I hadn't spotted this regression. I will install ITK and tweak the dicom/CMakeLists.txt so it doesn't compile with DCMTK that I have installed. I will have to do this tweak as the dicom plugin will always use DCTMK over ITK if DCMTK is found. This fact points to CMake not finding your local DCMTK install, so run ccmake . in the OpenSceneGraph/ directory and have a look at the variable settings, it might be that DCMTK has installed itself in an odd place that our find script hasn't spotted automatically. I have check in the two warning fixes and the compile fix in the ReaderWriterDICOM.cpp. Could you let me know how you get on. Robert. On Thu, May 12, 2011 at 7:28 PM, John Kelso <[email protected]> wrote: > Hi Robert, > > Please see below... > > On Thu, 12 May 2011, Robert Osfield wrote: > >> Hi John, >> >> Is you version of CentOS and old or recent one? > > As far as I know it's a fairly new one. If I type /proc/version I get this: > > Linux version 2.6.18-238.9.1.el5 ([email protected]) (gcc > version 4.1.2 20080704 (Red Hat 4.1.2-50)) #1 SMP Tue Apr 12 18:10:13 EDT > 2011 > > >> 2011/5/12 John Kelso <[email protected]>: >>> >>> When trying to build osg-2.9.14 using the same cmake command (and after >>> adding a trailing space to include/osg/GraphicsCostEstimator to get rid >>> of a >>> lot of annoying compiler warnings) I get: >> >> Could you pass on the warnings. I'm not getting any warnings on my >> Kubuntu system. Also you can explain exactly >> why and where you added a trailing space to GraphicsCostEstimator, >> ideally posting the modified file as well. > > I just finished rebuilding it with warnings enabled, and compressed > typescript and the CMakeCache.txt files are attached. I hope that's not a > no-no on this list. > > All I did to GraphicsCostEstimator was to add a newline at the end of the > last line. My mistake- it wasn't a space I added but a newline. > >>> [ 83%] Building CXX object >>> src/osgPlugins/dicom/CMakeFiles/osgdb_dicom.dir/ReaderWriterDICOM.o >>> >>> /usr/local/HEV-beta/external/osg/osg-2.9.14/OpenSceneGraph/include/osg/View:98: >>> warning: ‘struct osg::View::Slave’ has virtual functions but non-virtual >>> destructor >>> >>> /usr/local/HEV-beta/external/osg/osg-2.9.14/OpenSceneGraph/src/osgPlugins/dicom/ReaderWriterDICOM.cpp: >>> In member function ‘virtual osgDB::ReaderWriter::ReadResult >>> ReaderWriterDICOM::readImage(const std::string&, const osgDB::Options*) >>> const’: >>> >>> /usr/local/HEV-beta/external/osg/osg-2.9.14/OpenSceneGraph/src/osgPlugins/dicom/ReaderWriterDICOM.cp >> >> Curious. I'm build against DCMTK 3.6.1 and OSG svn/trunk without any >> problems. > > You got dcmtk 3.6.1? The latest I saw to download was 3.6.0. It's probably > not important... I hope. > > I did need to use a newer version of cmake than came with CentOS. I > installed a private copy of cmake 2.8.4 which I used to build OSG. As a > test I used this same version to build 2.9.10 and it worked fine, so I don't > think cmake's an issue. > >> >> What version of g++ do you have? On my system I have: >> >>> g++ --version >> >> g++ (Ubuntu/Linaro 4.5.2-8ubuntu4) 4.5.2 > > gcc-version: gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-50) > > Thanks again, > > John > _______________________________________________ > osg-users mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
