Hi Robert and all -- I'm concerned that there appear to be two different default values for the small feature culling pixel size threshold.

In CullingSet.cpp line 21:
    _smallFeatureCullingPixelSize=1.0f;

and in CullSettings.cpp line 35:
    _smallFeatureCullingPixelSize = 2.0f;

Certainly the behavior is deterministic, as one is probably set from the other before usage. My concern is just readability. Does anyone know what is the correct/preferred value? If so, I'll submit a code change so that both classes initialize to the same default value.

I'd also like to update the doxygen comments for the two setSmallFeatureCullingPixelSize() member functions to state how the pixel size parameter is interpreted by OSG. Is it a pixel circle radius, a pixel circle diameter, the length of the side of a pixel square region, or something else entirely? Currently the code comments don't describe it.

Finally, Robert, would you be open to a submission that allows the user to control this value with an environment variable?

Thanks,

--
  -Paul Martz      Skew Matrix Software
                   http://www.skew-matrix.com/

_______________________________________________
osg-users mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Reply via email to