HI Erik, On 26 March 2012 15:50, Erik den Dekker <e...@dendekker.com> wrote: > I see that you have recently run a script over the OSG code to (from commit > message 13041) 'remove trailing spaces and tabs'. While I am a proponent of > this effort and greatly appreciate the move, I do have some questions about > it: > > 1) Does the 'trailing' in this case also apply to tabs, or does it > mean you want to eradicate all tabs (replace them with spaces)?
For the recent check in the script I used removed trailing spaces and tabs. When I do a graphical merge I run a script that converts tabs to four spaces, although sometimes I have to tweak things to fix things. There are some older parts of bits that have been merged without me running the script than have tabs that I haven't yet converted. > 2) In current SVN head, I still encounter many files that contain > trailing whitespace, as well as files that contain tabs. Is it still work in > progress, are they forgotten, or is there a specific reason why you did not > apply the script to these particular parts of the codebase? I didn't do all the files as I wanted to make sure nothing broke in the process. So far no complaints... When I first started reading your post I did initial think oh uh something must have gone wrong... What parts are still spotting the training spaces? > I would like to offer you my assistance in this cause, if in any way you > would wish to use it. Point me in the direction of files/directories that still have training spaces would be useful. This is generally a low priority task though, it doesn't fix any bugs or make the code more readable. Robert. _______________________________________________ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
