Robert,

On 4/16/2013 5:26 AM, Robert Osfield wrote:
Hi Judson and Jeremy,

On 15 April 2013 22:15, Judson Weissert <[email protected] <mailto:[email protected]>> wrote:

    I know the feeling :) I am having difficulties trying to figure
    out the likelihood of circular references if the type is switched
    from observer_ptr to ref_ptr. I noticed that there are some
    clients that call the osgWidget::Callback constructor and pass
    "this" as the obj argument. That is, the callback IS an
    osgWidget::Window. Currently, I am not thinking clearly enough to
    identify the repercussions of the aforementioned behavior if the
    callbacks were stored as a ref_ptr. See osgwidgetnotebook for example.


I've looked at the code and the way the osgwidget examples use the addCallback() method and it looks to me like the list should be a ref_ptr<>, I looked for potential for circular references and didn't spot any. I've modified the code to use a ref_ptr<> and the osgwidget examples I tried all worked fine so have now checked this change into svn/trunk.

Thanks! I will test it some more on my end and post back to the list if I find any unintended consequences.

Regards,

Judson
_______________________________________________
osg-users mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Reply via email to