Hi Robert,

Thank you for your reply, I appreciate the amount of time you dedicate to the mailing list, and the OSG project in general.

On 1/8/2014 12:19 PM, Robert Osfield wrote:
Hi Judson,

Over the years we've found VS products lots of unhelpful warnings are perfectly correct code so we've had to resort to disabling them.

That is fair, I guess I am suggesting that the method in which they are disabled be reconsidered. The boost C++ libraries have some documentation on this topic as well.

See https://svn.boost.org/trac/boost/wiki/Guidelines/WarningsGuidelines

Adding lots special VS only pragmas to OSG code would be VERY painful to maintain so we don't do it. If you want to do it in your own code then fine, but we won't be doing it with the OSG, it's portable library that tries it best to be clean from platform specific workarounds.

I agree, the problem is that the platform specific workaround that is in there now has side effects that can be perceived as harmful.


If you don't want the warnings disabled then just select the Cmake option that doesn't defined OSG_DISABLE_MSVC_WARNINGS. Easy. This is why the Cmake option exists.

Indeed.


Robert.

Thank you,

Judson

_______________________________________________
osg-users mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Reply via email to