On Thu, 2006-11-02 at 00:46 +0000, Roger James wrote:
> I stuck the following mod in.

...

> #ifdef WIN32
>               std::string docUriString =
> doc->getDocumentURI()->getFilepath();
>               docUriString += doc->getDocumentURI()->getFile();
>               daeURI docUri( _strlwr( (char *)docUriString.c_str() ) );
>               imgif->getValue().makeRelativeTo( &docUri );
> #else
>         imgif->getValue().makeRelativeTo( doc->getDocumentURI() ); 
> #endif

I'd be concerned about this because it is writing URL into documents
that have been converted to lowercase, thus potentially making the
documents non-portable across platforms. Eg if the path part was
originally intercap in any way then it is going to break.

On Windows you want to do case-insensitive comparisons and yet remain
case-preserving on the output.

Regards,
Marcus


_______________________________________________
osg-users mailing list
[email protected]
http://openscenegraph.net/mailman/listinfo/osg-users
http://www.openscenegraph.org/

Reply via email to