Hi Björn,

On 11/6/06, Björn Hein <[EMAIL PROTECTED]> wrote:
StateSetManipulator.cpp (rev 1.12, l. 85): cyclePolygonMode() is called but
no aa.requestRedraw() afterwards. Is this intended?

Oh a refactoring of StateSetManipulator.cpp obvioulsy dropped the
requestRedraw().  Calling requestRedraw() is the correct way to ensure
that the window is redrawn, in practice most OSG based viewers just do
continuous update anyway so its not a bug you'd see as in a issue.

EventQueue.cpp (rev 1.8): in keyRelease & keyPressed KEY_Alt_R was mapped to
MODKEY_LEFT_ALT

This is most definitely a bug and with more detrimental effects.

I have now fixed both the above problems and checked them into CVS.

In SimpleViewer.cpp (rev. 1.5): in frameEventTraversal(): All eventHandlers
are called with ->handle(*event, *this, 0, 0); is this intended or should
this be xx->handle(*event, *this)?

Yes its intended.  The two versions of handle currently exist due to
the need for backwards compatibility and ability of event handlers to
function and scene graph callbacks.  The two parameters handle method
is the original method kept for backwards compatibility, the four
parameter handle method is the more generic version that allows usage
as a scene graph callback.  The four parameter method defaults to
mapping to the two mehtod one for compatibility.

SimpleViewer calls the four parameter method as not to miss any
possible overriding of the four parameter method over the original two
parameter one.

Robert.
_______________________________________________
osg-users mailing list
[email protected]
http://openscenegraph.net/mailman/listinfo/osg-users
http://www.openscenegraph.org/

Reply via email to