Hi Paul,

On 1/5/07, Paul Martz <[EMAIL PROTECTED]> wrote:
The comments for both ConvexPlanarPolygon and ConvexPlanarOccluder state
that "normals should point inwards (into the volume)". However, there
doesn't appear to be any methods in either class to allow an app to specify
normals. The corresponding .cpp files (including OccluderNode.cpp) don't
appear to use or implicitly generate normals.

Should these comments be removed?

Good question, perhaps rephrased would be better.  I'm a bit cold on
the topic right now - still half asleep, but from what I recall the
text is referring to the way that the planes are built up, the planes
have to have their normals pointing inwards.

The planes are computed on the fly though, so its really up to the
code generating these planes to ensure that everything is created
correctly Reflecting on this, the comment about planes pointing
inwards really should go into the Poytope class, and just checking,
its already there... so... the commend in the ConvexPlanar* class is
in not needed.

Although a better explanation would certainly not go amiss :-)

Robert.
_______________________________________________
osg-users mailing list
[email protected]
http://openscenegraph.net/mailman/listinfo/osg-users
http://www.openscenegraph.org/

Reply via email to