This is tricky. You can’t have a requirement that is conditional upon the platform.
You can have multiple resources that provide a capability, where each resource depends on a specific platform. We may need to follow a strategy similar to SWT, i.e. Gogo depends on some kind of “JLine native” capability, where the resource for that capability on Mac, Linux etc is essentially empty. Unfortunately this would increase the number of bundles required, on *all* platforms. Neil > On 9 Dec 2016, at 19:04, Guillaume Nodet <gnodet.apa...@gmail.com> wrote: > > If you know how to express a conditional package import, I'd be happy to add > it... > > Guillaume > > 2016-12-09 16:11 GMT+01:00 Tim Ward <tim.w...@paremus.com > <mailto:tim.w...@paremus.com>>: > To me that sounds like the bundle metadata needs enhancing. Ideally there > would be a way to make sure the Bndtools resolver knew it had to add one of > those bundles when on Windows! > > Tim > > Sent from my iPhone > > On 9 Dec 2016, at 06:48, Guillaume Nodet <gnodet.apa...@gmail.com > <mailto:gnodet.apa...@gmail.com>> wrote: > >> On windows, you need an additional bundle, either jansi or jna. >> With jline 3.0.2, this is not a strong requirement anymore (see [3] ), >> though the windows terminal is very limited without any of those additional >> bundles. >> >> Guillaume >> >> [1] http://repo1.maven.org/maven2/org/fusesource/jansi/jansi/1.14/ >> <http://repo1.maven.org/maven2/org/fusesource/jansi/jansi/1.14/> >> [2] http://repo1.maven.org/maven2/net/java/dev/jna/jna/4.2.2/ >> <http://repo1.maven.org/maven2/net/java/dev/jna/jna/4.2.2/> >> [3] >> https://github.com/jline/jline3/commit/ac603a2e428205505347523aeb9cbbe8ed2f2762 >> >> <https://github.com/jline/jline3/commit/ac603a2e428205505347523aeb9cbbe8ed2f2762> >> >> 2016-12-09 15:33 GMT+01:00 Peter Kriens <peter.kri...@aqute.biz >> <mailto:peter.kri...@aqute.biz>>: >> On Winows 7 I think: >>> Exception in thread "Gogo shell" java.lang.NoClassDefFoundError: >>> org/fusesource/jansi/WindowsAnsiOutputStream >>> at >>> org.jline.terminal.TerminalBuilder.doBuild(TerminalBuilder.java:146) >>> at >>> org.jline.terminal.TerminalBuilder.build(TerminalBuilder.java:109) >>> at org.apache.felix.gogo.jline.Ac >>> <http://org.apache.felix.gogo.jline.ac/>tivator.doStartShell(Activator.java:136) >>> at org.apache.felix.gogo.jline.Ac >>> <http://org.apache.felix.gogo.jline.ac/>tivator.lambda$startShell$0(Activator.java:106) >>> at java.lang.Thread.run(Unknown Source) >>> Caused by: java.lang.ClassNotFoundException: >>> org.fusesource.jansi.WindowsAnsiOutputStream cannot be found by >>> org.jline_3.0.0 >>> at >>> org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:439) >>> at >>> org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:352) >>> at >>> org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:344) >>> at >>> org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:160) >>> at java.lang.ClassLoader.loadClass(Unknown Source) >>> ... 5 more >> >> Thanks! Kind regards, >> >> Peter Kriens >> >>> On 9 Dec 2016, at 15:26, Guillaume Nodet <gnodet.apa...@gmail.com >>> <mailto:gnodet.apa...@gmail.com>> wrote: >>> >>> Do you have some pointers ? >>> I already fixed and released a bunch of issues in jline (latest of 3.0.x >>> branch is 3.0.3), but if there are more, i'd be happy to look at them, >>> whether you use it or not... >>> >>> 2016-12-09 13:41 GMT+01:00 Peter Kriens <peter.kri...@aqute.biz >>> <mailto:peter.kri...@aqute.biz>>: >>> I’ve reverted the osgi.enroute.gogo.shell.provider back to the good old >>> org.apache.felix.gogo.shell bundle. It looks like the JLine support was not >>> tested on windows and there are too many complaints. I tried the new Apache >>> Felix shell with JLine but there I got a similar error reported. >>> >>> Since I do not have time to go in depth it seems best to go to the working >>> although poorly old Gogo shell. >>> >>> Kind regards, >>> >>> Peter Kriens >>> >>> _______________________________________________ >>> OSGi Developer Mail List >>> osgi-dev@mail.osgi.org <mailto:osgi-dev@mail.osgi.org> >>> https://mail.osgi.org/mailman/listinfo/osgi-dev >>> <https://mail.osgi.org/mailman/listinfo/osgi-dev> >>> >>> >>> -- >>> ----------------------- >>> Guillaume Nodet >>> ------------------------ >>> Red Hat, Open Source Integration >>> >>> Email: gno...@redhat.com <mailto:gno...@redhat.com> >>> Web: http://fusesource.com <http://fusesource.com/> >>> Blog: http://gnodet.blogspot.com/ <http://gnodet.blogspot.com/> >>> >>> _______________________________________________ >>> OSGi Developer Mail List >>> osgi-dev@mail.osgi.org <mailto:osgi-dev@mail.osgi.org> >>> https://mail.osgi.org/mailman/listinfo/osgi-dev >>> <https://mail.osgi.org/mailman/listinfo/osgi-dev> >> >> _______________________________________________ >> OSGi Developer Mail List >> osgi-dev@mail.osgi.org <mailto:osgi-dev@mail.osgi.org> >> https://mail.osgi.org/mailman/listinfo/osgi-dev >> <https://mail.osgi.org/mailman/listinfo/osgi-dev> >> >> >> >> -- >> ----------------------- >> Guillaume Nodet >> ------------------------ >> Red Hat, Open Source Integration >> >> Email: gno...@redhat.com <mailto:gno...@redhat.com> >> Web: http://fusesource.com <http://fusesource.com/> >> Blog: http://gnodet.blogspot.com/ <http://gnodet.blogspot.com/> >> >> _______________________________________________ >> OSGi Developer Mail List >> osgi-dev@mail.osgi.org <mailto:osgi-dev@mail.osgi.org> >> https://mail.osgi.org/mailman/listinfo/osgi-dev >> <https://mail.osgi.org/mailman/listinfo/osgi-dev> > _______________________________________________ > OSGi Developer Mail List > osgi-dev@mail.osgi.org <mailto:osgi-dev@mail.osgi.org> > https://mail.osgi.org/mailman/listinfo/osgi-dev > <https://mail.osgi.org/mailman/listinfo/osgi-dev> > > > > -- > ----------------------- > Guillaume Nodet > ------------------------ > Red Hat, Open Source Integration > > Email: gno...@redhat.com <mailto:gno...@redhat.com> > Web: http://fusesource.com <http://fusesource.com/> > Blog: http://gnodet.blogspot.com/ <http://gnodet.blogspot.com/> > > _______________________________________________ > OSGi Developer Mail List > osgi-dev@mail.osgi.org > https://mail.osgi.org/mailman/listinfo/osgi-dev
_______________________________________________ OSGi Developer Mail List osgi-dev@mail.osgi.org https://mail.osgi.org/mailman/listinfo/osgi-dev
