Hi,
thanks for reminding us and sorry for not responding to your bug earlier.
Yes, it makes sense to support the same way of commenting. We probably
will remove the usage of "#" for comments and allow the same comments as
in the configurator spec.
I'll update the bug accordingly
Regards
Carsten
On 15.04.2020 22:19, Stefan Bischof via osgi-dev wrote:
Hello,
I have some Questions/Comments on Comments in Features (RFC 241)
It would be nice to have the same ways to Comment in Features and Configurator
Spec.
When reading rfc 241, I can see in the Example that an key that starts(?) with
a `#` is an comment:
```
{
"# some" : "comment",
"#" : "key starts with hast es enough",
"key" : "value"
}
```
The spec of the[
Configurator:](https://osgi.org/specification/osgi.cmpn/7.0.0/service.configurator.html#d0e131566)
```
{
// Comment
/*
* More comments
*/
"key" : "value"
}
```
1. It may help to add some Comments in the form of JSMin (The JavaScript
Minifier) comments ( // and /* */ ) to your example to point out that this is
also valid.
2. It would be nice to have more information about - how to do comment
´´´
"#" : "Is it only Key must start with an #?",
"#" : "is having same key twice also okay?",
"# foo" : "# bar is okay"
"#": null;
"#": { "fooComment", "barComment"};
"#": ["and",
"this",
"?"],
´´´
3. Does that mean, that Service-Properties/Configurations with the name "#"
couldn't be set using the features configuration? Or will every comment in the
configurator section be handled as an component-property?
some Months ago i filed the same Questions
herehttps://osgi.org/bugzilla/show_bug.cgi?id=234
_______________________________________________
OSGi Developer Mail List
osgi-dev@mail.osgi.org
https://mail.osgi.org/mailman/listinfo/osgi-dev
--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org
_______________________________________________
OSGi Developer Mail List
osgi-dev@mail.osgi.org
https://mail.osgi.org/mailman/listinfo/osgi-dev
