This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "SCCP Library".

The branch, pre_release has been updated
  discards  ad2db7aedd625da964c6856056fcd16519dbc3b7 (commit)
  discards  fd63ccca545fdeebd2a621ac41fc5f5d9c1b2d80 (commit)
  discards  75ed8def84103db9a3ae22d5ebce8d2cb84aacc8 (commit)
  discards  b75258e51a4efb6cff2f3e956b50fa020233c6c2 (commit)
  discards  3c3f70a2457f437f07836280eaebe9f5c6a7514c (commit)
  discards  02f7c45b69c9f2d71b34eef059a43929a831d65e (commit)
  discards  b35f6d1c1e81a3d4187915234ca332fc26a0858b (commit)
  discards  06956848a3ec1b64c6bb3d71abde8db44440d80f (commit)
       via  9d1a3f66457508e16dd2d1d33fe7bf5ed24b633b (commit)
       via  2373f2778a135e4fc37ff5c741ac3293b18b8d87 (commit)
       via  e634a6f3251cf556ca8d1466b044775e44a48a79 (commit)
       via  037d46abc181d5a763f2171a5e08154eb163fd0c (commit)
       via  603e065f43a9b0a6d9d92584ba458fefee32b516 (commit)
       via  c881c4912709be005cbb3ffb02ba06f13c69d24b (commit)
       via  775ac6f6b1c47066db58608f9497f0e4916bbcc4 (commit)
       via  a212398f7c39ab0e919e0c9efde8a1c8a37678bb (commit)
       via  b352ca030d8870930493f36e2b3702760ff4b44a (commit)
       via  b711e1450444c5882a8d9a941094183484fa47db (commit)
       via  81a029a4e46bb7c62b2401ec055fe44c5b7568cd (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (ad2db7aedd625da964c6856056fcd16519dbc3b7)
             N -- N -- N (9d1a3f66457508e16dd2d1d33fe7bf5ed24b633b)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 9d1a3f66457508e16dd2d1d33fe7bf5ed24b633b
Author: Neels Hofmeyr <>
Date:   Thu Jul 27 17:33:06 2017 +0200

    cosmetic: ws in log
    Change-Id: If5a56ec170d4e91ce070f6fa9c9cfe5bbc121186

commit 2373f2778a135e4fc37ff5c741ac3293b18b8d87
Author: Neels Hofmeyr <>
Date:   Wed Jul 26 18:15:47 2017 +0200

    sccp_helpers: check buf len in append_to_buf()
    Change-Id: I2e6d656871f952be8e719573fedf2154832841d7

commit e634a6f3251cf556ca8d1466b044775e44a48a79
Author: Neels Hofmeyr <>
Date:   Thu Jul 27 13:53:03 2017 +0200

    sccp-addr vty: set RI to SSN_PC when setting a point-code
    Change-Id: I75c67d289693f1c2a049ac61cf2b2097d6e5687d

commit 037d46abc181d5a763f2171a5e08154eb163fd0c
Author: Neels Hofmeyr <>
Date:   Thu Jul 27 15:22:06 2017 +0200

    fix osmo_sccp_addr_dump(): actually print RI
    Adjust xua_test accordingly.
    Change-Id: I93e0aa706867e7b1de7f7a6071e3c8af89772af0

commit 603e065f43a9b0a6d9d92584ba458fefee32b516
Author: Neels Hofmeyr <>
Date:   Wed Jul 26 18:07:53 2017 +0200

    add osmo_sccp_addr_name() and three value_string[]s
    osmo_sccp_addr_dump() just prints the raw values. In osmo_sccp_addr_name(), 
    osmo_ss7_pointcode_print() and newly added RI, SSN and GT value_string[] to
    print more human readable log output.
    Change-Id: Ie1aedd7894acd69ddc887cd65a8a0df4b888838c

commit c881c4912709be005cbb3ffb02ba06f13c69d24b
Author: Neels Hofmeyr <>
Date:   Thu Jul 27 13:51:46 2017 +0200

    introduce OSMO_SCCP_RI_NONE to indicate unset RI
    Allows to automatically set an RI in future change
    "sccp-addr vty: set RI to SSN_PC when setting a point-code"
    Change-Id: I6e2f31b023b08cba2f2ee8234e6108efcaca41c0

commit 775ac6f6b1c47066db58608f9497f0e4916bbcc4
Author: Neels Hofmeyr <>
Date:   Thu Jul 27 13:50:31 2017 +0200

    constify ss7_instance arg of osmo_ss7_pointcode_print()
    Change-Id: I8c6b7188d004033e75e9c41f4a65c418d13a79c5

commit a212398f7c39ab0e919e0c9efde8a1c8a37678bb
Author: Neels Hofmeyr <>
Date:   Wed Jul 26 17:31:53 2017 +0200

    consistency: use OSMO_SS7_PC_INVALID for osmo_sccp_user
    A previous patch added ss7_instance primary_pc validity checks by means of
    OSMO_SS7_PC_INVALID. To be consistent, also adjust sccp_user accordingly.
    (see I7f0f0c89b7335d9da24161bfac8234be214ca00c)
    Remove the osmo_sccp_user's pc_valid field, replaced by 
    Adjust all code paths.
    Simplify some log printing, using the fact that osmo_ss7_pointcode_print() 
    outputs "(no PC)" for unset point codes.
    Change-Id: I8684c9b559712072c772012890bbf7efa7c8eb35

commit b352ca030d8870930493f36e2b3702760ff4b44a
Author: Neels Hofmeyr <>
Date:   Wed Jul 26 17:31:53 2017 +0200

    ensure valid primary_pc in osmo_ss7_instance
    Initialize osmo_ss7_instance.cfg.primary_pc = OSMO_SS7_PC_INVALID.
    Adjust all code paths using primary_pc to ensure it is indeed valid.
    It looks like we are going to use the primary point-code of an SS7 instance 
    derive a local SCCP address, e.g. for osmo-bsc and osmo-hnbgw.
     cs7-instance 1
      point-code 1.2.3   ! sets osmo_ss7_instance.primary_pc = 1.2.3
      sccp-address msc
       point-code 0.0.1
       routing-indicator PC
       remote-addr msc   ! derives cs7 instance 1 and local pc 1.2.3
    If 'point-code 1.2.3' is omitted, this becomes '0.0.0' without the user
    noticing, and this happens for each client that omits it. I would like to 
    when no local PC is set.
    Change-Id: I7f0f0c89b7335d9da24161bfac8234be214ca00c

commit b711e1450444c5882a8d9a941094183484fa47db
Author: Neels Hofmeyr <>
Date:   Wed Jul 26 17:31:53 2017 +0200

    add OSMO_SS7_PC_INVALID, add osmo_ss7_pc_is_valid()
    Introduce OSMO_SS7_PC_INVALID to mark an unset point code.
    Add static osmo_ss7_pc_is_valid() (name matches schema of
    In osmo_ss7_pointcode_print(), return "(no PC)" if !osmo_ss7_pc_is_valid(), 
    convenient printing of any PC state.
    Subsequent patches will use this for
    osmo_ss7_instance (I7f0f0c89b7335d9da24161bfac8234be214ca00c)
    as well as osmo_sccp_user (I8684c9b559712072c772012890bbf7efa7c8eb35).
    Currently, in osmo_ss7_vty.c we had "if (inst->cfg.primary_pc)" suggesting 
0 is
    invalid, but in struct osmo_sccp_user we have flag pc_valid suggesting 0 is
    indeed valid. All known point code formats are <= 24bit, so we can easily 
    0xffffffff as indicator for an unset PC, which removes the need to remember 
    set a second field for validity and keeps the structs nice and lean.
    Change-Id: Ib5715bf03a4de7713a7a809dfd821c700255ba8c


Summary of changes:
 include/osmocom/sigtran/osmo_ss7.h |  9 ++++-
 include/osmocom/sigtran/sccp_sap.h |  2 +
 src/osmo_ss7.c                     | 16 ++++++--
 src/osmo_ss7_vty.c                 |  5 +--
 src/sccp_internal.h                |  1 -
 src/sccp_scoc.c                    | 12 ++----
 src/sccp_scrc.c                    |  2 +-
 src/sccp_user.c                    | 81 +++++++++++++++++++++++++++-----------
 src/sccp_vty.c                     |  2 +-
 tests/ss7/ss7_test.c               |  1 -
 10 files changed, 88 insertions(+), 43 deletions(-)

SCCP Library

Reply via email to