On 07/14/2014 06:02 AM, Sylvain Munaut wrote:
Hi,
Is there interest from the rtl-sdr maintainers in my pursuing this?
I think there is definitive interest.
But it also touches a part of the code that's been a source of many
issues before, and so will require a *bunch* of testing to make sure
it doesn't break anything either. Including testing on other platforms
like Windows and OSX. So don't expect it to be merged on a whim.
I'd also encourage readers on those platforms (win/osx) to test this
patch and report, and even when people on linux. We don't have access
to every platform out there and we rely on people actually testing
this and reporting back their results.
Excellent. Yes, please do test: my only available systems are
Ubuntu-based (mostly 12.04-LTS with different hardware enablement
stacks), and validating it on Windows and other versions of libusb is
clearly important. I'd like to see some feedback.
I'm continuing to add minor patches for edge cases to the
fix-libusb-segv-r2 branch. At the moment I sometimes see a shutdown
from interrupt taking a few seconds; I'm continuing to evaluate that.
You can see the cumulative differences at any time at:
https://github.com/pabigot/rtl-sdr/compare/pabigot:master...fix-libusb-segv-r2
Once there's feedback from others confirming that it works and the
maintainers are ready for it, I'll roll an -r3 so the upstream history
is clean. Personally I think what's there now is very pretty (but then
I would, wouldn't I).
Peter
