On Sat, 06 Sep 2014 16:06:28 +0200
Alexander Kurpiers <[email protected]> wrote:

> Next try...

Looks good as far as general structure goes. Style is a little odd,
perhaps. For example, /* Check the error code. */ comment is useless,
straight from the book of "a=b; /* assign a value of b to a */".
When you unroll, the ideom is  while(i--). If you hide the decrement
inside a [] inside the loop body, it's liable to get missed one day.
But I'll let the maintainer take issues with style. You got the gist
of it right, I think.

-- Pete

Reply via email to