Hi Brett, Here's a new patch containing the tag filter and associated classes: http://global_void.mailc.net/TagFilter.07DEC2009.patch
I applied it to the current svn trunk locally, and the ant checkstyle and dist targets now finish successfully. > * There is a compilation warning. At least there is in Eclipse. > There is a "private Class filterClass" variable in TagFilter > that has a warning because Class is a generic type and no type > is specified. You can fix it with something like "private > Class<? extends EntityContainer> filterClass". This has been fixed. > class like PostgreSqlDatasetTruncator as an example. The type > of logging you're writing out would probably be suitable for a > "finer" level of logging. The debug messages are now log entries at the 'finer' level. > * Do you have any unit tests? Nothing too extravagant is > required, but a couple of simple tests would be very helpful. I have added three basic junit tests. The only test failures I see during the build are those that depend on a database. Just let me know if you run into any other problems. -Andrew _______________________________________________ osmosis-dev mailing list [email protected] http://lists.openstreetmap.org/listinfo/osmosis-dev
