On Sun, Mar 11, 2018 at 10:19:21AM +0000, Brett Henderson wrote: > *osmformat.proto* > Are these changes mastered somewhere else? In other words, are these new > fields the same ones used by Osmium in its implementation? I'm wondering > if we need to re-sync from the main OSM-binary project. The osmosis > version is the same as that in https://github.com/scrosby/OSM-binary. The > repo https://github.com/brettch/OSM-binary is a fork of that, and the > osmosis branch there *is* the same code as the osmosis-osm-binary directory > in the osmosis repo, just with some re-arranging to fit inside the Osmosis > structure and fit inside the Osmosis java package namespace. > > *Jochen* (if you're reading), where does Osmium source its osmformat.proto > file from?
The PBF implementation in Osmium doesn't need the .proto file, so this didn't come up there. > Long story short, rather than make changes directly to the file in Osmosis > and create a fork, should we apply them to upstream first and then re-sync > Osmosis with that? Yes, we should do this upstream in https://github.com/scrosby/OSM-binary. If somebody creates a pull request, I'll merge it there... Jochen -- Jochen Topf joc...@remote.org https://www.jochentopf.com/ +49-351-31778688 _______________________________________________ osmosis-dev mailing list email@example.com https://lists.openstreetmap.org/listinfo/osmosis-dev