If you're familiar with VS2017 and development on Windows, feel free to enable all warnings but then disable warnings that are not critical (think: indentation, etc.).
I think our AppVeyor build is also quite spammy in that regard. The main problem is the core devs don't run Windows :) On Mon, Sep 11, 2017 at 1:25 PM, Mateusz Loskot <[email protected]> wrote: > On 11 September 2017 at 12:34, Daniel Hofmann <[email protected]> wrote: > > This Wiki page is a bit outdated; for example there are a few compiler > > warnings on old compilers in combination with specific boost versions. > > AFAICT, compiling with VS 2017 for 64-bit target gives me ~3.5K warnings, > though from narrow set of issues: > > C4067 > C4101 > C4146 > C4244 > C4267 > C4305 > C4309 > C4373 > C4396 > C4717 > C4800 > > > That said we should check warnings for Travis (and the Windows CI ..) and > > especially our production builds. > > Unless there is -Werror policy, warnings are (almost) never checked :-) > > > I think a "coding standard" boils down to: > > - adapt your naming convention to what's already present in the code base > > - use clang-format for formatting > > - include what you use > > Sounds good. > > > Anyway, I asked out of curiosity (seeing largish number of warnings w/ > VS2017). > > Best regards, > -- > Mateusz Loskot, http://mateusz.loskot.net > > _______________________________________________ > OSRM-talk mailing list > [email protected] > https://lists.openstreetmap.org/listinfo/osrm-talk >
_______________________________________________ OSRM-talk mailing list [email protected] https://lists.openstreetmap.org/listinfo/osrm-talk
