On Friday 20 June 2008 01:00:35 Dev Mazumdar wrote: > Yair K. wrote: > > Build 1016, sblive.c: > > > > if ((devc->card_type == SB_AUDIGY) || (devc->card_type == SB_AUDIGY2) || > > (devc > > ->card_type == SB_AUDIGY2VAL)) > > ... > > devc->card_type = SB_AUDIGY | SB_AUDIGY2 | SB_AUDIGY2VAL; > > > > *sigh* This was fixed properly in hg. No idea why simply (card_type & > > SB_AUDIGY) wasn't done here. > > > > Yours, > > Yair K. > > _______________________________________________ > > oss-devel mailing list > > oss-devel@mailman.opensound.com > > http://mailman.opensound.com/mailman/listinfo/oss-devel > > > the problem is that audigy4 didn't work so I put back the code - i'll > check the exact reason why the test fails. >
The original test (and the build 1016 code) always fails for any type of audigy card except simple SB_AUDIGY, since it tests for equality not mask. I know of a case where the analog output code was required for an Audigy2 card to work: http://4front-tech.com/forum/viewtopic.php?p=8843#8843 . I'm certain that this can be disabled for audigy4 only, or enabled for audigy2 only (Maybe this works only on some pci ids, and something like SB_AUDIGY_CAN_SET_OUTPUT should be added to features_mask?). (I've only noticed the change back due to http://4front-tech.com/forum/viewtopic.php?t=2736 who thinks he needs the analog output too). Yours, Yair K. _______________________________________________ oss-devel mailing list oss-devel@mailman.opensound.com http://mailman.opensound.com/mailman/listinfo/oss-devel