Hi Yair,

I applied your second patch (most of it). See comments below:

Yair K. wrote:
> Hi,
>
>    The attached patch does the following:
>       1) Run ossdetect after inserting a USB device using hal policy file.
>       Two files are added at setup/Linux/scripts: oss_usb-create-devices and 
> 90-oss_usb-create-device.fdi.
>       They are installed into scripts/ and symlinked to hal directories by 
> build.sh. (oss_usb-create-devices should have 755 permissions). The location 
> match defaults for hal 0.50+.
>       Thanks to Ionic for testing the scripts.
>   
Ok.
>       2) Add a --enable-libsalsa=YES|NO option to configure. Default is YES, 
> but using NO will prevent trying to compile it.
>
>   
Ok.
>       3) Don't touch devlists on $SRCDIR in build.sh. No idea why this was 
> done in the first place, but it adds unwanted changes to hg if running 
> configure from hg repo directory. (Linux/FreeBSD/SCO. Last two are untested, 
> but should work).
>   
I didn't remove the $SRCDIR/devlists stuff. This mechanism is used to 
automatically update supported device lists for each operating system 
and CPU architecture. I have a scrit that converts these files to HTML 
and uploads them to the web site as supported sound card list. I need to 
add more intelligent way to update these files only when full OSS is 
compiled (including the drivers that are not available in open source).
>       4) tutorials -
>               A) Add some more programs to samples/Makefile.
>               B) samples/mmap_duplex.c - Comment and actual use don't match:
>   
>> int frag = 0xffff0008;       /* 32 fragments of 2^8=256 bytes */
>>     
>               Should be 0x00200008, no? This should be fixed in manual site 
> too:
> http://manuals.opensound.com/developer/mmap_duplex.c.html#LOC2
>               (Noticed by someone on #oss, can't remember handle).
>   
Right. I have changed this program without updating the coments.
>               C) Add SNDCTL_DSP_SYNC to playchar() morse/morse.c. Otherwise, 
> I get some crackling after playing 'w'.
>   
This is not necessary. The morse.c program is supposed to take it's 
input from a file or to be used as an end of a pipe. Use of 
SNDCTL_DSP_SYNC is not proper in this program.

The morse2.c program is the one that supports live keyboard input.

Best regards,

Hannu
_______________________________________________
oss-devel mailing list
oss-devel@mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel

Reply via email to