Hi,

There was a bug. oss_install_audiodev_with_devname() tried to set the 
devname string to empty after using it. This was incorrect and 
unnecessary. I changed this parameter to be a const string. Now in the hg.

Best regards,

Hannu
--------
François Revol wrote:
> in kernel/framework/audio/oss_audio_core.c
> line 6279
> *devfile_name is assigned to 0
> while the parameter is defined as char *, all drivers give it pointers 
> to const strings or inlined in the call even as ...with_devname(..., 
> "foo");
> This is both unclean and incorrect.
> I thought the BeOS port crashed due to missing stuff on update, but 
> it's just that the text segment of the module is mapped read-only, 
> which of course won't work with this line.
> So I suggest removing this line, and making the argument const char *.
>
> François.
>
> _______________________________________________
> oss-devel mailing list
> oss-devel@mailman.opensound.com
> http://mailman.opensound.com/mailman/listinfo/oss-devel
>   

_______________________________________________
oss-devel mailing list
oss-devel@mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel

Reply via email to