Yair K. kirjoitti: > Hi, > > The attached patch does the following: > A) Make sure that the mixer control name is NULL-terminated in the case > that dupes are detected ( kernel/framework/mixer_core.c ). Previously this > could overflow (e.g. http://pastebin.com/d205fb130 ). > B) Use OSS_MIXERDEV in ossdevlinks and osstest too. I didn't apply this change to osstest, ossdevlinks and savemixer. These utilities should use hardcoded /dev/mixer in all cases. Otherwise there is a risk that some user is signed in as root under a thin client session and damages the configuration by running these utilities. It might be usefull to support OSS_MIXERDEV in osstest but some option needs to be added so that this can be bypassed. > Keep C89 compatibility for ossplay. > C) Finally make the test for audigy_digital_din work correctly with > audigy2 while still allowing the analog output option. Just do not activate > it unless the user specifically changed the default to use the analog output. >
Otherwise the patch looks OK. I have also applied the previous two patches. However I will not upload the changes to the hg server before having chance to verify them. Best regards, Hannu _______________________________________________ oss-devel mailing list oss-devel@mailman.opensound.com http://mailman.opensound.com/mailman/listinfo/oss-devel
