On Saturday, 25 בApril 2009 20:00:51 Will Keaney wrote:
> Yair K. wrote:
> > On Saturday, 25 April 2009 17:46:55 Will Keaney wrote:
> > > OSS modules won't build against kernel 2.6.30 right now. This patch
> > > addresses that by changing from the apparently deprecated dev.bus_id to
> > > dev_name(), and was created using a fresh checkout from the mercurial,
> > > last changeset 735:b75dd483cb27.
> > >
> > > Will Keaney
> > > uberpinguin
> >
> > Wouldn't this patch need some check again LINUX_VERSION_CODE, so that
> > OSS will compile against earlier Linux versions? Per lxr.linux.no
> > early 2.6.x didn't have this function.
> >
> >
> > Yours,
> > Yair K.
> >
> >
> > diff -r 9cad50985f54 setup/Linux/oss/build/osscore.c
> > --- a/setup/Linux/oss/build/osscore.c Wed Apr 15 08:49:00 2009 +0300
> > +++ b/setup/Linux/oss/build/osscore.c Sat Apr 25 18:23:55 2009 +0300
> > char *
> > oss_pci_read_devpath (dev_info_t * dip)
> > {
> > +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,30)
> > + return dev_name(dip->pcidev);
> > +#else
> > return dip->pcidev->dev.bus_id;
> > +#endif
> > }
> >
> > int
>
> Ah, you're right.  I hadn't thought of that.  Once I've figured out how
> to implement it, I'll submit a revised patch.
>
> Will

I included a revised version. I should have asked whether it worked for you.

Yours,
        Yair K.
_______________________________________________
oss-devel mailing list
oss-devel@mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel

Reply via email to