On Friday, 29 בMay 2009 09:11:49 Hannu Savolainen wrote:
> Yair K. wrote:
> > On Monday, 18 בMay 2009 16:58:56 Hannu Savolainen wrote:
> > > Hi,
> > >
> > > I forgot to mention that now the GRC3 sample rate conversion quality
> > > setting (src_quality) in osscore.conf is limited to level 3 (high)
> > > only. The vmix src setting in mixer shows only "Fast" and "High" as the
> > > alternatives. There is no noticeable difference between the levels and
> > > leaving the extra coefficient tables out saves significant amounts of
> > > memory.
> >
> > Hi,
> >
> >
> > I suggest adding the OFF option back again.
>
> Good. Apparently I forgot to re-enable that option. In addition the
> "Fast" mode should only be enabled when vmix is configured to use
> floating point (until somebody implements that mode in the fixed point
> version).

Hi,

The rev. 781 change is obviously wrong, since it doesn't enable "Fast" at all 
(the version sent to the ML was better). The attached patch should do it 
correctly.

Yours,
        Yair K.


diff -r 33014b7ce581 kernel/framework/vmix_core/vmix_core.c
--- a/kernel/framework/vmix_core/vmix_core.c	Fri May 29 11:09:04 2009 +0300
+++ b/kernel/framework/vmix_core/vmix_core.c	Fri May 29 15:37:24 2009 +0300
@@ -368,16 +368,18 @@
 		int i;
 		
   		memset (ext->enum_present, 0, sizeof (ext->enum_present));
-#ifdef CONFIG_OSS_VMIX_FLOAT
-		ext->enum_present[0] = 0x01; // "Fast" is always present
-#endif
-		ext->enum_present[0] = 0x040; // As well as "OFF"
+		ext->enum_present[0] = 0x040; // "OFF" is always present
 #if CONFIG_OSS_GRC_MAX_QUALITY > 7
 #error CONFIG_OSS_GRC_MAX_QUALITY is out of range
 #endif
 
 		for (i=CONFIG_OSS_GRC_MIN_QUALITY; i <= CONFIG_OSS_GRC_MAX_QUALITY; i++)
 			ext->enum_present[0] |= (1 << i);
+#ifndef CONFIG_OSS_VMIX_FLOAT
+		ext->enum_present[0] &= ~0x01; // "Fast" isn't implemented in fixed mode yet
+#else
+		ext->enum_present[0] |= 0x01; // "Fast" is always present
+#endif
 	}
 
       /*
_______________________________________________
oss-devel mailing list
oss-devel@mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel

Reply via email to