On Tue July 14 2009 22:59:13 Hannu Savolainen wrote:
> Yair K. wrote:
> > On Tue July 14 2009 04:43:35 Yair K. wrote:
> >> B) oss_hdaudio: Reset TCSEL (the register which controls PCI
> >> Express QOS) to TC0 for intel HDAudios. Some BIOSes set it to TC7 which
> >> creates noise on playback as OSS doesn't support this.
> >
> > Note to self: Don't do anything that late at night. This part is stupid
> > for an obvious reason...
>
> I already applied this patch. Could you send me a counter patch if
> necessary?
Sure.
I looked under intel specific part, and didn't notice driver did that register
change later below...
Yours,
Yair K.
diff -r 3f5b8d321096 kernel/drv/oss_hdaudio/oss_hdaudio.c
--- a/kernel/drv/oss_hdaudio/oss_hdaudio.c Tue Jul 14 23:04:43 2009 +0300
+++ b/kernel/drv/oss_hdaudio/oss_hdaudio.c Tue Jul 14 23:23:59 2009 +0300
@@ -1810,9 +1810,6 @@
case INTEL_DEVICE_ICH10_B:
case INTEL_DEVICE_PCH:
devc->chip_name = "Intel HD Audio";
- /* Reset TCSEL to TC0 */
- pci_read_config_byte (osdev, 0x44, &btmp);
- pci_write_config_byte (osdev, 0x44, btmp & 0xf8);
break;
case NVIDIA_DEVICE_MCP51:
_______________________________________________
oss-devel mailing list
oss-devel@mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel
