Hi Vikas,

Many thanks. GFixed now.

Best regards,

Hannu
-----
vikas chauhan wrote:
> Hi Hannu,
> One more probable typo bug at a number of places ,
> 
> oss_audio_core.c
> ************************************************************************ (
> from oss_audio_set_format() )
> 
> 400:   adev->user_parms.fmt = fmt;
> 401:   if (adev->dmask & DMASK_OUT)
> 402:     {
> 403:        adev->dmap_out->flags |= DMAP_COOKED;
> 404:     }
> 405:
> 406:   if (adev->dmask & DMASK_OUT)
> 407:     {
> 408:        adev->dmap_in->flags |= DMAP_COOKED;
> 409:     }
> 410:
> 411:   /* If the device is in 16 bit format then just return */
> 412:   if (ret & (AFMT_S16_LE | AFMT_S16_BE))
> 413:      return fmt;
> 
> ************************************************************************** (
> from oss_audio_set_channels() )
> 
> 483:   if (ret > 1 && (adev->flags & ADEV_NONINTERLEAVED))
> 484:    {
> 485:        if (adev->dmask & DMASK_OUT)
> 486:           adev->dmap_out->flags |= DMAP_COOKED;
> 487:
> 488:        if (adev->dmask & DMASK_OUT)
> 489:           adev->dmap_in->flags |= DMAP_COOKED;
> 480:    }
> 
> ...
> 
> 512:   adev->user_parms.channels = ch;
> 513:   if (adev->dmask & DMASK_OUT)
> 514:    {
> 515:       adev->dmap_out->flags |= DMAP_COOKED;
> 516:    }
> 517:
> 518:   if (adev->dmask & DMASK_OUT)
> 519:    {
> 520:       adev->dmap_in->flags |= DMAP_COOKED;
> 521:    }
> 522:
> 523:   return ch;
> 
> 
> *******************************************************************************
> ( from oss_audio_set_rate() )
> 
> 568:  /*
> 569:   * Needs to perform format conversions
> 570:   */
> 571:
> 572:   adev->user_parms.rate = rate;
> 573:   if (adev->dmask & DMASK_OUT)
> 574:    {
> 575:       adev->dmap_out->flags |= DMAP_COOKED;
> 576:    }
> 577:
> 578:   if (adev->dmask & DMASK_OUT)
> 579:    {
> 580:       adev->dmap_in->flags |= DMAP_COOKED;
> 581:    }
> 582:
> 583:   return rate;
> 584: #endif
> 
> ****************************************************************************
> 
> 
> 
> In lines 406, 488, 518 and 578 , comparison should be made against DMASK_IN
> .
> 
> Regards,
> Vikas
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> oss-devel mailing list
> oss-devel@mailman.opensound.com
> http://mailman.opensound.com/mailman/listinfo/oss-devel

_______________________________________________
oss-devel mailing list
oss-devel@mailman.opensound.com
http://mailman.opensound.com/mailman/listinfo/oss-devel

Reply via email to