Hey, I've applied your corrections. Thanks
https://github.com/ossec/ossec-hids/pull/217 Best Regards, Hakisho Nukama On Fri, May 30, 2014 at 10:27 AM, Christian Hettler <[email protected]> wrote: > hello, > > please put the '+' before the '-'. > "[.-+]" is an invalid range. > > Christian > > On Wed, May 28, 2014 at 01:07:42PM +0000, Hakisho Nukama wrote: >> Done and tested with escaped \+: https://github.com/ossec/ossec-hids/pull/216 >> >> Best Regards, >> Hakisho Nukama >> >> On Wed, May 28, 2014 at 12:21 PM, Jeremy Rossi <[email protected]> >> wrote: >> > https://github.com/ossec/ossec-hids/blob/master/install.sh#L475 >> > Looks like the Valid_email_addresses regex does not allow +. Something >> > that I know people use a fair amount. worth fixing and should be easy >> > if someone wants to create a quick pull request. >> > + grep -E "^[a-zA-Z0-9_.-+]{1,36}@[a-zA-Z0-9_.-]{1,54}$" >> > - grep -E "^[a-zA-Z0-9_.-]{1,36}@[a-zA-Z0-9_.-]{1,54}$" >> > >> > Sorry once again on train and dont have pull terminal access. >> > -Jeremy Rossi >> > * Hakisho Nukama <[email protected]> [2014-05-28 09:07:32 +0000]: >> > >> >> Hi, >> >> >> >> I've cloned the github repository just yesterday and run the >> >> install.sh on a FreeBSD 10 installation. >> >> >> >> I've set up a filter for name+ossec on my email account. >> >> Entering an email address [1] into the prompt during install.sh >> >> results in the prompt again. >> >> The address isn't accepted. >> >> >> >> This email address works perfectly, when entered into ossec.conf. >> >> >> >> So what are you thoughts about this minor issue? >> >> >> >> Best Regards, >> >> Hakisho Nukama >> >> >> >> [1] https://en.wikipedia.org/wiki/Email_address#Valid_email_addresses >> >> >> >> -- >> >> >> >> --- >> >> You received this message because you are subscribed to the Google Groups >> >> "ossec-list" group. >> >> To unsubscribe from this group and stop receiving emails from it, send an >> >> email to [email protected]. >> >> For more options, visit https://groups.google.com/d/optout. >> > >> > >> > -- >> > >> > --- You received this message because you are subscribed to the Google >> > Groups "ossec-list" group. >> > To unsubscribe from this group and stop receiving emails from it, send an >> > email to [email protected]. >> > For more options, visit https://groups.google.com/d/optout. >> >> -- >> >> --- >> You received this message because you are subscribed to the Google Groups >> "ossec-list" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. > > -- > > --- > You received this message because you are subscribed to the Google Groups > "ossec-list" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- --- You received this message because you are subscribed to the Google Groups "ossec-list" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
