On Thu, Dec 22, 2016 at 7:34 AM, Waldek Kozaczuk <[email protected]> wrote:
> I sent a patch that fixes the issue by reorganizing the module java-test > and essentially making it require 'java' instead of 'java-base'. > Unfortunately because scripts/module.py is order sensitive as far as image > parameter goes > Yes. It seems that the "require" feature is depth-first, i.e., the first module we require (or list on the build line) will require something else, which will be loaded on the stop. So " image=java-tests,openjdk8-fedora" command just happened to work > because java module combined all files that are right now in more than one > module. > So I don't understand how this ever worked... Wouldn't "java-tests" try to add the "java" module (the default Java 7 one), and then "openjdk8-fedora" add a different set of files? Didn't we get a random combination of these two sets of files, or something? > > In any case is it possible to change jenkins configuration to use this: > > scripts/build -j4 image=openjdk8-fedora,java-tests && scripts/test.py > --name java.* > instead of > scripts/build -j4 image=java-tests,openjdk8-fedora && scripts/test.py > --name java.* > *Avi*, can you please make that change in Jenkins? I don't know how to control it. > > Otherwise I will have to come up with a different idea to fix it. > > Regards, > Waldek > > On Wed, Dec 21, 2016 at 8:08 AM, Nadav Har'El <[email protected]> wrote: > >> >> On Wed, Dec 21, 2016 at 2:20 PM, Waldek Kozaczuk <[email protected]> >> wrote: >> >>> Great catch. It looks like I missed to test this combination ('make >>> check' does not trigger this one). Does it mean that jenkins jobs do more >>> than make check? >>> >> >> Yes, it does a few more things we at some point deemed useful to check >> (and necessarily any exhaustive set of applications). It also checks >> tomcat, for example. >> >> >>> >>> I will fix it. >>> >> >> Thanks. >> Nadav. >> > > -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
