Dne torek, 22. avgust 2017 17.42.46 UTC+2 je oseba Gregor Berginc napisala: > > > > On Tuesday, 22 August 2017 17:27:36 UTC+2, Justin Cinkelj wrote: >> >> I will assume that std:: and boost:: cannot be used in early in >> loader.cc. >> >> with stresep, arguments with spaces cannot be quoted, but the spaces can >> be escaped. So >> --env=AAA="aa bb" >> cannot be used, but instead we can use >> --env=AAA=aa\ bb >> > > As far as I am concerned, it was established that the two parts of the > boot command are parsed differently already, so I see no big issue with the > requirement to escape the spaces in the first part! Please keep in mind > that we initially requested this feature because we needed to pass env > variables with spaces from Capstan. Having said that, we SHOULD be able to > escape such strings within Capstan prior to setting it to the boot command. > > Best, > -Gregor > > >> The commands.cc can than directly receive unparsed/original cmdline, >> just after the loader options. >> So in that part of cmdline, escaping should work, I think (it is >> boost::spirit::qi based). >> >> It is sort of ugly, if second part of cmdline will support escaping and >> quoting, but first part will support only escaping. >> > I don't mind if there is a different way of escaping --env part than the arguments itself, as long as there is at least one way of doing it :) As Gregor said, we will shape the bootcmd from within Capstan (user won't bother doing it manually) so the complication that you describe will be hidden from end user.
> But in order to be lazy, I would like to go via that path. >> >> Nadav, Miha, Gregor, rest - you opinion please. Any better ideas? >> >> Justin >> > -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
