Hello Nadav/All, To be honest, I didn't have any technical reason to do so So, feel free to discard the whole set I would consider only the changes on setup.py because it adds support for linux mint (which personally use) I promise i won't send any random patch like these :) Sorry for those 'newbieness', first time trying to contribute
Kind Regads, Geraldo Netto Sapere Aude => Non dvcor, dvco http://exdev.sf.net/ On 13 February 2018 at 20:34, Nadav Har'El <n...@scylladb.com> wrote: > > On Tue, Feb 13, 2018 at 3:24 PM, geraldo netto <geraldone...@gmail.com> > wrote: > >> small cleanups based on pylint >> > > May I ask, why are cosmetic overhauls like this a good idea, and not just > churn and work for both you and the committers? > > > >> as for fsize, it was removed because it was never used in any part of the >> code >> >> geraldo netto (3): >> imgedit.py: reorganise imports to meet pylint >> imgedit.py: add one space to popen() call >> imgedit.py: remove variable fsize once it's never used >> >> scripts/imgedit.py | 9 ++++----- >> 1 file changed, 4 insertions(+), 5 deletions(-) >> >> -- >> 2.7.4 >> >> -- >> You received this message because you are subscribed to the Google Groups >> "OSv Development" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to osv-dev+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to osv-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.