Another surprise,
unzip is not installed too
(just to remember, the same debian 9 stable with the package groups "ssh
server" and "standard system utilities")

login as: netto
[email protected]'s password:
Linux debian 4.9.0-4-amd64 #1 SMP Debian 4.9.65-3+deb9u1 (2017-12-23) x86_64

The programs included with the Debian GNU/Linux system are free software;
the exact distribution terms for each program are described in the
individual files in /usr/share/doc/*/copyright.

Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent
permitted by applicable law.
Last login: Sun Feb 18 15:50:15 2018
netto@debian:~$ unzip
-bash: unzip: command not found
netto@debian:~$ su -
Password:
root@debian:~# apt-get install unzip
Reading package lists... Done
Building dependency tree
Reading state information... Done
Suggested packages:
  zip
The following NEW packages will be installed:
  unzip
0 upgraded, 1 newly installed, 0 to remove and 1 not upgraded.
Need to get 170 kB of archives.
After this operation, 547 kB of additional disk space will be used.
Get:1 http://debian.c3sl.ufpr.br/debian stretch/main amd64 unzip amd64
6.0-21 [170 kB]
Fetched 170 kB in 10s (16.3 kB/s)
Selecting previously unselected package unzip.
(Reading database ... 27530 files and directories currently installed.)
Preparing to unpack .../unzip_6.0-21_amd64.deb ...
Unpacking unzip (6.0-21) ...
Processing triggers for mime-support (3.60) ...
Setting up unzip (6.0-21) ...
Processing triggers for man-db (2.7.6.1-2) ...


Kind Regards,

Geraldo Netto
Sapere Aude => Non dvcor, dvco
http://exdev.sf.net/

On 18 February 2018 at 15:41, Geraldo Netto <[email protected]> wrote:

> Hello Nadav/All,
>
> I can confirm debian has no curl by default (!!!)
> This is a Debian 9 64 bits setup with only 2 groups of packages "ssh
> server" and "standard system utilities"
> I'll add curl to the debian list
>
> login as: netto
> [email protected]'s password:
> Linux debian 4.9.0-4-amd64 #1 SMP Debian 4.9.65-3+deb9u1 (2017-12-23)
> x86_64
>
> The programs included with the Debian GNU/Linux system are free software;
> the exact distribution terms for each program are described in the
> individual files in /usr/share/doc/*/copyright.
>
> Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent
> permitted by applicable law.
> netto@debian:~$ curl
> -bash: curl: command not found
> netto@debian:~$ su -
> Password:
> root@debian:~# apt-get install curl
> Reading package lists... Done
> Building dependency tree
> Reading state information... Done
> The following additional packages will be installed:
>   libcurl3
> The following NEW packages will be installed:
>   curl libcurl3
> 0 upgraded, 2 newly installed, 0 to remove and 1 not upgraded.
> Need to get 518 kB of archives.
> After this operation, 989 kB of additional disk space will be used.
> Do you want to continue? [Y/n]
> Get:1 http://security.debian.org/debian-security stretch/updates/main
> amd64 libcurl3 amd64 7.52.1-5+deb9u4 [291 kB]
> Get:2 http://security.debian.org/debian-security stretch/updates/main
> amd64 curl amd64 7.52.1-5+deb9u4 [227 kB]
> Fetched 518 kB in 0s (1,516 kB/s)
> Selecting previously unselected package libcurl3:amd64.
> (Reading database ... 27513 files and directories currently installed.)
> Preparing to unpack .../libcurl3_7.52.1-5+deb9u4_amd64.deb ...
> Unpacking libcurl3:amd64 (7.52.1-5+deb9u4) ...
> Selecting previously unselected package curl.
> Preparing to unpack .../curl_7.52.1-5+deb9u4_amd64.deb ...
> Unpacking curl (7.52.1-5+deb9u4) ...
> Setting up libcurl3:amd64 (7.52.1-5+deb9u4) ...
> Processing triggers for libc-bin (2.24-11+deb9u1) ...
> Processing triggers for man-db (2.7.6.1-2) ...
> Setting up curl (7.52.1-5+deb9u4) ...
> root@debian:~#
>
>
>
> Kind Regards,
>
> Geraldo Netto
> Sapere Aude => Non dvcor, dvco
> http://exdev.sf.net/
>
> On 18 February 2018 at 09:38, Nadav Har'El <[email protected]> wrote:
>
>>
>> On Sat, Feb 17, 2018 at 4:00 PM, Geraldo Netto <[email protected]>
>> wrote:
>>
>>> Hello Nadav/All,
>>>
>>> While I agree that sorting the names sounds totally irrelevant
>>> I think this makes things much clear, specially when adding new packages
>>> to the list
>>>
>>
>> Ok, I'll reconsider, trusting you that you didn't change any of the
>> content during the sort (I can't verify this easily in my review).
>>
>>
>>> Because it is much easier to read the list of dependencies for a certain
>>> distribution
>>> apt or yum are smart enough to handle the dependencies, so, sorting
>>> should not break the process
>>>
>>> Also:
>>> - I just noticed that Debian class is missing the unzip package, maybe
>>> unzip is installed by default, but I would still add to the package list
>>> just in case
>>>   (it is easier to read the dependencies now, because they are sorted
>>> and therefore, I can directly compare with the dependencies of other
>>> distributions)
>>>
>>
>> I have a hunch that nobody tested this on pure Debian recently (Ubuntu is
>> listed separately!), which is why nobody noticed unzip is missing.
>> I doubt it is installed by default, although many advanced users will
>> certainly have it installed.
>>
>> That being said, please don't go adding random packages which you think
>> are missing to Debian's list - if you
>> want to change Debian's list, you'll need to get a Debian machine (or VM
>> or Docker container) and test that
>> your changes actually work on Debian.
>>
>>
>>> - Fedora class has no reference to curl, but only to wget, once again,
>>> maybe curl is installed by default, but I would still add to the package
>>> list
>>>   (the same situation here, because it was sorted, it was quick to find
>>> that curl is not in fedora list)
>>>
>>
>> I guess this is true. Probably installed by default, yes. I can confirm
>> the package name is "curl" on Fedora, and it's safe to add.
>>
>>
>>
>>> - there are some other cases like this
>>>
>>> Also, we could further optimise it because, for example, maven is maven,
>>> unzip is unzip in all distributions that we support
>>> So, we could create a single list of shared dependencies and just use it
>>>
>>
>> I'm not sure this is worth the trouble, but perhaps.
>>
>>
>>>
>>>
>>> Kind Regards,
>>>
>>> Geraldo Netto
>>> Sapere Aude => Non dvcor, dvco
>>> http://exdev.sf.net/
>>>
>>> On 14 February 2018 at 10:10, Nadav Har'El <[email protected]> wrote:
>>>
>>>> There is no good way for me to review this patch (to confirm you didn't
>>>> forget any of the packages while sorting them)...
>>>> Why is this important or even useful to have the package names sorted?
>>>>
>>>>
>>>> --
>>>> Nadav Har'El
>>>> [email protected]
>>>>
>>>> On Tue, Feb 13, 2018 at 7:07 PM, geraldo netto <[email protected]>
>>>> wrote:
>>>>
>>>>> Signed-off-by: geraldo netto <[email protected]>
>>>>> ---
>>>>>  scripts/setup.py | 143 ++++++++++++++++++++++++++++++
>>>>> ++++++++++++++-----------
>>>>>  1 file changed, 114 insertions(+), 29 deletions(-)
>>>>>
>>>>> diff --git a/scripts/setup.py b/scripts/setup.py
>>>>> index 41aa976..766454f 100755
>>>>> --- a/scripts/setup.py
>>>>> +++ b/scripts/setup.py
>>>>> @@ -25,13 +25,38 @@ standard_ec2_post_install = ['pip install awscli
>>>>> &&'
>>>>>  class Fedora(object):
>>>>>      name = 'Fedora'
>>>>>      install = 'yum -y install --allowerasing'
>>>>> -    packages = ['gcc-c++', 'gcc-c++-aarch64-linux-gnu', 'git', 'gdb',
>>>>> 'qemu-img',
>>>>> -                'qemu-system-x86', 'libvirt', 'maven',
>>>>> -                'ant', 'autoconf', 'automake', 'boost-static',
>>>>> 'genromfs', 'libtool',
>>>>> -                'flex', 'bison', 'maven-shade-plugin', 'python-dpkt',
>>>>> 'tcpdump', 'gdb',
>>>>> -                'gnutls-utils', 'openssl', 'p11-kit', 'patch', 'wget',
>>>>> -                'unzip', 'ncurses', 'ncurses-devel',
>>>>> 'libstdc++-static', 'openssl-libs',
>>>>> -                'libedit-devel', 'yaml-cpp-devel'
>>>>> +    packages = [
>>>>> +                'ant',
>>>>> +                'autoconf',
>>>>> +                'automake',
>>>>> +                'bison',
>>>>> +                'boost-static',
>>>>> +                'flex',
>>>>> +                'gcc-c++',
>>>>> +                'gcc-c++-aarch64-linux-gnu',
>>>>> +                'gdb',
>>>>> +                'genromfs',
>>>>> +                'git',
>>>>> +                'gnutls-utils',
>>>>> +                'libedit-devel',
>>>>> +                'libstdc++-static',
>>>>> +                'libtool',
>>>>> +                'libvirt',
>>>>> +                'maven',
>>>>> +                'maven-shade-plugin',
>>>>> +                'ncurses',
>>>>> +                'ncurses-devel',
>>>>> +                'openssl',
>>>>> +                'openssl-libs',
>>>>> +                'p11-kit',
>>>>> +                'patch',
>>>>> +                'python-dpkt',
>>>>> +                'qemu-img',
>>>>> +                'qemu-system-x86',
>>>>> +                'tcpdump',
>>>>> +                'unzip',
>>>>> +                'wget',
>>>>> +                'yaml-cpp-devel',
>>>>>                  ]
>>>>>      ec2_packages = standard_ec2_packages
>>>>>      test_packages = ['openssl-devel']
>>>>> @@ -103,8 +128,7 @@ class Fedora(object):
>>>>>      versions = [Fedora_19, Fedora_20, Fedora_21, Fedora_22,
>>>>> Fedora_23, Fedora_24, Fedora_25, Fedora_26, Fedora_27]
>>>>>
>>>>>  class RHELbased(Fedora):
>>>>> -    name = ['Scientific Linux', 'NauLinux', 'CentOS Linux',
>>>>> -            'Red Hat Enterprise Linux', 'Oracle Linux']
>>>>> +    name = ['Scientific Linux', 'NauLinux', 'CentOS Linux', 'Red Hat
>>>>> Enterprise Linux', 'Oracle Linux']
>>>>>
>>>>>      class RHELbased_70(object):
>>>>>          packages = []
>>>>> @@ -139,12 +163,32 @@ class RHELbased(Fedora):
>>>>>  class Debian(object):
>>>>>      name = 'debian'
>>>>>      install = 'apt-get -y install'
>>>>> -    packages = ['build-essential', 'libboost-all-dev', 'genromfs',
>>>>> 'autoconf',
>>>>> -                'libtool', 'openjdk-7-jdk', 'ant', 'maven',
>>>>> -                'libmaven-shade-plugin-java', 'tcpdump', 'gdb',
>>>>> 'gawk',
>>>>> -                'gnutls-bin', 'openssl', 'python-requests',
>>>>> 'python-dpkt',
>>>>> -                'qemu-system-x86', 'qemu-utils',
>>>>> 'lib32stdc++-4.9-dev',
>>>>> -                'p11-kit', 'libssl-dev', 'libedit-dev',
>>>>> 'libncurses5-dev']
>>>>> +    packages = [
>>>>> +                'ant',
>>>>> +                'autoconf',
>>>>> +                'build-essential',
>>>>> +                'gawk',
>>>>> +                'gdb',
>>>>> +                'genromfs',
>>>>> +                'gnutls-bin',
>>>>> +                'lib32stdc++-4.9-dev',
>>>>> +                'libboost-all-dev',
>>>>> +                'libedit-dev',
>>>>> +                'libmaven-shade-plugin-java',
>>>>> +                'libncurses5-dev',
>>>>> +                'libssl-dev',
>>>>> +                'libtool',
>>>>> +                'maven',
>>>>> +                'openjdk-7-jdk',
>>>>> +                'openssl',
>>>>> +                'p11-kit',
>>>>> +                'python-dpkt',
>>>>> +                'python-requests',
>>>>> +                'qemu-system-x86',
>>>>> +                'qemu-utils',
>>>>> +                'tcpdump',
>>>>> +                ]
>>>>> +
>>>>>      ec2_packages = standard_ec2_packages
>>>>>      test_packages = ['libssl-dev', 'zip']
>>>>>      ec2_post_install = None
>>>>> @@ -161,12 +205,33 @@ class Debian(object):
>>>>>  class Ubuntu(object):
>>>>>      name = 'Ubuntu'
>>>>>      install = 'apt-get -y install'
>>>>> -    packages = ['build-essential', 'libboost-all-dev', 'genromfs',
>>>>> 'autoconf',
>>>>> -                'libtool', 'ant', 'qemu-utils', 'maven',
>>>>> -                'libmaven-shade-plugin-java', 'python-dpkt',
>>>>> 'tcpdump', 'gdb', 'qemu-system-x86',
>>>>> -                'gawk', 'gnutls-bin', 'openssl', 'python-requests',
>>>>> 'p11-kit', 'g++-multilib',
>>>>> -                'libssl-dev', 'libedit-dev', 'curl', 'libvirt-bin',
>>>>> -                'libncurses5-dev', 'libyaml-cpp-dev', 'unzip'
>>>>> +    packages = [
>>>>> +                'ant',
>>>>> +                'autoconf',
>>>>> +                'build-essential',
>>>>> +                'curl',
>>>>> +                'g++-multilib',
>>>>> +                'gawk',
>>>>> +                'gdb',
>>>>> +                'genromfs',
>>>>> +                'gnutls-bin',
>>>>> +                'libboost-all-dev',
>>>>> +                'libedit-dev',
>>>>> +                'libmaven-shade-plugin-java',
>>>>> +                'libncurses5-dev',
>>>>> +                'libssl-dev',
>>>>> +                'libtool',
>>>>> +                'libvirt-bin',
>>>>> +                'libyaml-cpp-dev',
>>>>> +                'maven',
>>>>> +                'openssl',
>>>>> +                'p11-kit',
>>>>> +                'python-dpkt',
>>>>> +                'python-requests',
>>>>> +                'qemu-system-x86',
>>>>> +                'qemu-utils',
>>>>> +                'tcpdump',
>>>>> +                'unzip',
>>>>>                  ]
>>>>>      ec2_packages = standard_ec2_packages
>>>>>      test_packages = ['libssl-dev', 'zip']
>>>>> @@ -212,14 +277,34 @@ class Ubuntu(object):
>>>>>  class LinuxMint(object):
>>>>>      name = 'LinuxMint'
>>>>>      install = 'apt-get -y install'
>>>>> -    packages = ['build-essential', 'libboost-all-dev', 'genromfs',
>>>>> 'autoconf',
>>>>> -                'libtool', 'ant', 'maven',
>>>>> -                'libmaven-shade-plugin-java', 'tcpdump', 'gdb',
>>>>> 'gawk',
>>>>> -                'gnutls-bin', 'openssl', 'python-requests',
>>>>> 'python-dpkt',
>>>>> -                'qemu-system-x86', 'qemu-utils', 'g++-multilib',
>>>>> -                               'curl', 'libvirt-bin',
>>>>> 'libyaml-cpp-dev', 'unzip',
>>>>> -                'p11-kit', 'libssl-dev', 'libedit-dev',
>>>>> 'libncurses5-dev'
>>>>> -                               ]
>>>>> +    packages = [
>>>>> +                'ant',
>>>>> +                'autoconf',
>>>>> +                'build-essential',
>>>>> +                'curl',
>>>>> +                'g++-multilib',
>>>>> +                'gawk',
>>>>> +                'gdb',
>>>>> +                'genromfs',
>>>>> +                'gnutls-bin',
>>>>> +                'libboost-all-dev',
>>>>> +                'libedit-dev',
>>>>> +                'libmaven-shade-plugin-java',
>>>>> +                'libncurses5-dev',
>>>>> +                'libssl-dev',
>>>>> +                'libtool',
>>>>> +                'libvirt-bin',
>>>>> +                'libyaml-cpp-dev',
>>>>> +                'maven',
>>>>> +                'openssl',
>>>>> +                'p11-kit',
>>>>> +                'python-dpkt',
>>>>> +                'python-requests',
>>>>> +                'qemu-system-x86',
>>>>> +                'qemu-utils',
>>>>> +                'tcpdump',
>>>>> +                'unzip',
>>>>> +               ]
>>>>>      ec2_packages = standard_ec2_packages
>>>>>      test_packages = ['libssl-dev', 'zip']
>>>>>      ec2_post_install = None
>>>>> --
>>>>> 2.7.4
>>>>>
>>>>> --
>>>>> You received this message because you are subscribed to the Google
>>>>> Groups "OSv Development" group.
>>>>> To unsubscribe from this group and stop receiving emails from it, send
>>>>> an email to [email protected].
>>>>> For more options, visit https://groups.google.com/d/optout.
>>>>>
>>>>
>>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "OSv Development" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to [email protected].
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups "OSv 
Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to