Hi. 

I reviewed this and other patch and replied on the the mailing list. Have my 
replies not reached you ?

Waldek

Sent from my iPhone

> On Apr 11, 2018, at 22:15, Wang Yu <yuw...@linux.alibaba.com> wrote:
> 
> no one review?
> 
> 
>> 在 18/4/9 下午8:37, Wang Yu 写道:
>> before patch boot with --bootchart, "TLS initialization"
>> is not output
>>    ...
>>    disk read (real mode): 50.71ms, (+50.71ms)
>>    .init functions: 89.20ms, (+5.48ms)
>>    SMP launched: 90.56ms, (+1.36ms)
>>    VFS initialized: 95.76ms, (+5.20ms)
>>    ...
>> after patch,
>>    ...
>>    disk read (real mode): 50.71ms, (+50.71ms)
>>    TLS initialization: 83.72ms, (+33.01ms)
>>    .init functions: 89.20ms, (+5.48ms)
>>    SMP launched: 90.56ms, (+1.36ms)
>>    VFS initialized: 95.76ms, (+5.20ms)
>>    ...
>> Signed-off-by: Wang Yu <yuw...@linux.alibaba.com>
>> ---
>>  include/osv/boot.hh | 4 ++--
>>  loader.cc           | 1 +
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>> 
>> diff --git a/include/osv/boot.hh b/include/osv/boot.hh
>> index eb97cc9..ec5301c 100644
>> --- a/include/osv/boot.hh
>> +++ b/include/osv/boot.hh
>> @@ -15,13 +15,13 @@ public:
>>      void print_chart();
>>      time_element arrays[16];
>>      friend void arch_setup_free_memory();
>> -private:
>>      // Can we keep it at 0 and let the initial two users increment it?  No, 
>> we
>>      // cannot. The reason is that the code that *parses* those fields run
>>      // relatively late (the code that takes the measure is so early it 
>> cannot
>>      // call this one directly. Therefore, the measurements would appear in 
>> the
>>      // middle of the list, and we want to preserve order.
>> -    int _event = 2;
>> +    int _event = 3;
>> +private:
>>        void print_one_time(int index);
>>      double to_msec(u64 time);
>> diff --git a/loader.cc b/loader.cc
>> index f6cbd4d..0d97151 100644
>> --- a/loader.cc
>> +++ b/loader.cc
>> @@ -109,6 +109,7 @@ void premain()
>>      }
>>        setup_tls(inittab);
>> +    boot_time._event=2;
>>      boot_time.event("TLS initialization");
>>      for (auto init = inittab.start; init < inittab.start + inittab.count; 
>> ++init) {
>>          (*init)();
> 
> -- 
> You received this message because you are subscribed to a topic in the Google 
> Groups "OSv Development" group.
> To unsubscribe from this topic, visit 
> https://groups.google.com/d/topic/osv-dev/XWBt6oDA6_4/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to 
> osv-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups "OSv 
Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to osv-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to