On Mon, Nov 5, 2018 at 9:25 AM Commit Bot <[email protected]> wrote:
> From: Waldemar Kozaczuk <[email protected]> > Committer: Waldemar Kozaczuk <[email protected]> > Branch: master > > Fix UIO_MAXIOV redefine warning when compiling some httpserver warnings > > Some httpserver-api include host uio.h header indirectly through > boost libraries headers and osv/include/uio.h which both define > UIO_MAXIOV. To prevent the collision we #undef this macro > in osv/uio.h just before we define OSv version of it. > I am not against this specific fix (which is trivial and fairly harmless), but I think this may indicate something wrong in the httpserver-api/Makefile. Perhaps the error is that the INCLUDES there does -I../../include but not -I../../include/api - and this is where <sys/uio.h> which Boost ASI includes lives. > > Signed-off-by: Waldemar Kozaczuk <[email protected]> > > --- > diff --git a/include/osv/uio.h b/include/osv/uio.h > --- a/include/osv/uio.h > +++ b/include/osv/uio.h > @@ -48,6 +48,7 @@ enum uio_rw { UIO_READ, UIO_WRITE }; > */ > #define IOSIZE_MAX INT_MAX > > +#undef UIO_MAXIOV > #define UIO_MAXIOV 1024 > > #define UIO_SYSSPACE 0 > > -- > You received this message because you are subscribed to the Google Groups > "OSv Development" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
