Hello,

On Wed, Jan 16, 2019 at 7:21 AM Waldemar Kozaczuk <[email protected]>
wrote:

> This patch refactors virtio layer in order to support
> modern PCI and mmio devices. It is essentially a step 0
> in the list of tasks to make OSv boot on AWS firecracker.
>
> This patch introduces virtio_device class that abstracts
> virtio transport layer. That way virtio_driver class and
> its specializations can interact with host without being
> tied to a specific transport (PCI, mmio, etc).
>
> The virtio_pci_device, virtio_legacy_pci_device and
> virtio_modern_pci_device
> classes define specializations of virtio_device for PCI transport.
> This patch effectively moves all PCI-related logic from virtio_driver
> to virtio_legacy_pci_device classi and effectively virtio drivers
> transport agnostic. Followup patches will provide implementations
> of virtio_modern_pci_device and future virtio_mmio_device.
>
> The interrupt_factory struct defines a mechanism used
> by virtio drivers to specify particulars of creating/registering
> proper interrupt logic for each transport.
>

You coud make this patch even simpler to review by deferring the
introduction of virtio_modern_pci_device in a follow up patch.

But for the overall approach:

Acked-by: Pekka Enberg <[email protected]>

- Pekka

-- 
You received this message because you are subscribed to the Google Groups "OSv 
Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to