On Wed, Jan 16, 2019 at 8:57 AM Waldek Kozaczuk <[email protected]> wrote: > > One of the virtio devices supported by OSv is assigned_virtio. To best of my > knowledge (based on what Nadav wrote) this driver has been invented in order > to better integrate OSv with seastar (see #ifdef HAVE_OSV in > https://github.com/scylladb/seastar/blob/e3466851e047ec7494c983b4f316e1a4464a4945/src/net/virtio.cc#L56). > > I am not sure if anybody is relying on this feature. If you do then please > let me know. Otherwise I am planning to send a patch that will remove this > functionality from OSv. Doing so will allow to significantly simplify the > patch that refactors OSv virtio stack in order to support modern virtio PCI > devices and mmio devices (see > https://groups.google.com/d/msg/osv-dev/NIDG5zLLv0A/bE69BwI7EwAJ for > details). At this point I do not even have a way to test this patch without > seastar. So I am thinking it is simply dead code that can be removed (the > less code the better). > > Anybody who relies on it please shout otherwise I will be sending a patch to > remove this feature.
I think you can safely remove it unless we hear about a user who object with good arguments. > > Regards, > Waldek > > -- > You received this message because you are subscribed to the Google Groups > "OSv Development" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
