Think I found/fixed it Let me finish the tests to make sure, I'm not missing anything else
See You, Geraldo Netto Sapere Aude => Non dvcor, dvco http://exdev.sf.net/ On Sun, 10 Mar 2019 at 16:52, Geraldo Netto <[email protected]> wrote: > Nadav/Waldek, > > It turns out that module.py is not resolving java8 > and in fact it sems broken also for other apps like elastic search which > also requires jdk8 > I'm checking why... > the workaround fr tomcat and all other apps that depend on java8 is to use > image=openjdk8-zulu-full,<the app you want> > > the log: > ... > Building into build/release.x64 > ./scripts/build image=tomcat > make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent > make rule. > make[1]: Entering directory '/home/netto/Desktop/osv' > Building into build/release.x64 > GEN gen/include/osv/version.h > make[1]: Leaving directory '/home/netto/Desktop/osv' > No such image configuration: tomcat. Assuming list of modules. > Importing /home/netto/Desktop/osv/apps/tomcat/module.py > Traceback (most recent call last): > File "scripts/module.py", line 281, in <module> > args.func(args) > File "scripts/module.py", line 205, in build > api.require_running(name) > File "/home/netto/Desktop/osv/scripts/osv/modules/resolve.py", line 194, > in require_running > module = require(module_name) > File "/home/netto/Desktop/osv/scripts/osv/modules/resolve.py", line 169, > in require > module_properties = local_import(module_file) > File "/home/netto/Desktop/osv/scripts/osv/modules/resolve.py", line 48, > in local_import > return runpy.run_path(path) > File "/usr/lib/python2.7/runpy.py", line 252, in run_path > return _run_module_code(code, init_globals, run_name, path_name) > File "/usr/lib/python2.7/runpy.py", line 82, in _run_module_code > mod_name, mod_fname, mod_loader, pkg_name) > File "/usr/lib/python2.7/runpy.py", line 72, in _run_code > exec code in run_globals > File "/home/netto/Desktop/osv/apps/tomcat/module.py", line 3, in <module> > api.require('java8') > File "/home/netto/Desktop/osv/scripts/osv/modules/resolve.py", line 152, > in require > raise Exception("Module not found: %s. Please check configuration: %s" > % (module_name, get_config_path())) > Exception: Module not found: java8. Please check configuration: > /home/netto/Desktop/osv/config.json > ./scripts/build failed: fs_type=$fs_type jdkbase=$jdkbase ARCH=$arch > mode=$mode OSV_BASE=$SRC OSV_BUILD_PATH=$OSV_BUILD_PATH scripts/module.py > $j_arg build -c $modules $usrskel_arg $no_required_arg > > > Kind Regards, > > Geraldo Netto > Sapere Aude => Non dvcor, dvco > http://exdev.sf.net/ > > > On Sun, 10 Mar 2019 at 16:35, Nadav Har'El <[email protected]> wrote: > >> I already committed your previous patch so please make an incremental >> patch. Thanks. >> >> On Sun, Mar 10, 2019, 17:11 Geraldo Netto <[email protected]> wrote: >> >>> Hey, >>> >>> I beg your pardon by this I forgot to point the jdk8 requirement once >>> I usually build with "openjdk8-zulu-full,tomcat" :( >>> let me do another patch with it >>> Do you prefer me to make a single patch or would you prefer me to make >>> a new set and also fix some comment? >>> >>> >>> Kind Regards, >>> >>> Geraldo Netto >>> Sapere Aude => Non dvcor, dvco >>> http://exdev.sf.net/ >>> >>> On Sun, 10 Mar 2019 at 16:04, Nadav Har'El <[email protected]> wrote: >>> > >>> > Thanks. I committed your patches, because there's no halting progress >>> :-) >>> > But does it work for you? It doesn't for me... When I try >>> > >>> > $ scripts/build image=tomcat >>> > $ scripts/run >>> > >>> > I get: >>> > >>> > java.so: Starting JVM app using: >>> io/osv/nonisolated/RunNonIsolatedJvmApp >>> > java.so: Setting Java system classloader to >>> NonIsolatingOsvSystemClassLoader >>> > io.osv.AppThreadTerminatedWithUncaughtException: >>> java.lang.UnsupportedClassVersionError: >>> org/apache/catalina/startup/Bootstrap : Unsupported major.minor version 52.0 >>> > at >>> io.osv.nonisolated.NonIsolatedJvm.runSync(NonIsolatedJvm.java:81) >>> > at io.osv.RunJvmAppHelper.runSync(RunJvmAppHelper.java:40) >>> > at >>> io.osv.nonisolated.RunNonIsolatedJvmApp.main(RunNonIsolatedJvmApp.java:34) >>> > Caused by: java.lang.UnsupportedClassVersionError: >>> org/apache/catalina/startup/Bootstrap : Unsupported major.minor version 52.0 >>> > >>> > Is it possible that we compile Tomcat in a way it can't run on the >>> antique Java (version 7) we supply by default? >>> > Is this a new Tomcat requirement, that it only runs on Java 8? If it >>> is, we need to have tomcat "require" Java 8, not just any java (which today >>> is Java 7). >>> > >>> > Anyway, I wonder how it worked for you? >>> > >>> > -- >>> > Nadav Har'El >>> > [email protected] >>> > >>> > >>> > On Sat, Mar 9, 2019 at 3:02 AM geraldo netto <[email protected]> >>> wrote: >>> >> >>> >> geraldo netto (9): >>> >> tomcat: upgrade from 8.0.15 to 9.0.16 >>> >> update 0001-configure-web-admin-user.patch >>> >> add admin-gui permission >>> >> add manager-script permission >>> >> rename: 0003-assign-admin-gui-role-to-tomcat-user -> >>> >> 0002-assign-admin-gui-role-to-tomcat-user >>> >> renamed: 0002-change-http-port-to-8081.patch -> >>> >> 0003-change-http-port-to-8081.patch >>> >> renamed: 0006-Add-script-managment-role-to-tomcat-user.patch -> >>> >> 0003-Add-script-managment-role-to-tomcat-user.patch >>> >> renamed: 0003-change-http-port-to-8081.patch -> >>> >> 0006-change-http-port-to-8081.patch >>> >> update bio connector to nio >>> >> >>> >> tomcat/GET | 20 >>> ++++++++++--------- >>> >> .../perf/0001-configure-web-admin-user.patch | 15 ++++---------- >>> >> ...ssign-admin-gui-role-to-tomcat-user.patch} | 10 +++++----- >>> >> ...cript-managment-role-to-tomcat-user.patch} | 10 +++++----- >>> >> ...ch => 0006-change-http-port-to-8081.patch} | 0 >>> >> ...> 0007-Use-nio-connector-explicitly.patch} | 4 ++-- >>> >> 6 files changed, 27 insertions(+), 32 deletions(-) >>> >> rename >>> tomcat/patches/perf/{0003-assign-admin-gui-role-to-tomcat-user.patch => >>> 0002-assign-admin-gui-role-to-tomcat-user.patch} (64%) >>> >> rename >>> tomcat/patches/perf/{0006-Add-script-managment-role-to-tomcat-user.patch => >>> 0003-Add-script-managment-role-to-tomcat-user.patch} (70%) >>> >> rename tomcat/patches/perf/{0002-change-http-port-to-8081.patch => >>> 0006-change-http-port-to-8081.patch} (100%) >>> >> rename tomcat/patches/perf/{0007-Use-bio-connector-explicitly.patch >>> => 0007-Use-nio-connector-explicitly.patch} (91%) >>> >> >>> >> -- >>> >> 2.17.1 >>> >> >>> >> -- >>> >> You received this message because you are subscribed to the Google >>> Groups "OSv Development" group. >>> >> To unsubscribe from this group and stop receiving emails from it, >>> send an email to [email protected]. >>> >> For more options, visit https://groups.google.com/d/optout. >>> >> -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
