On Mon, 2020-05-25 at 09:15 +0300, Nadav Har'El wrote: > > Do you mean > https://github.com/cloudius-systems/osv/commit/d52cb12546ff2acd5255a2ac8897891e421f07dc > which just turned off optimization?
Yes. > At the time, I suggested the memset() fix for #913, because seemed to > me like an "obvious" caused for infinite recursion (which happened > now in Fedora 32). But you said you tested and it didn't help - in > your case you saw that memset() wasn't even used (you commented it > out and everything still compiled fine). Right, I recall at the time that the memset fix looked like it should do it, but didn't. > So I guess we can't revert the turn-off-optimization patch. Maybe > it's not actually needed for modern compilers (you can check...) but > it will still be needed for the specific compiler which caused you > problem #913 in the first place. I suspect it was a compiler issue, as I can't reproduce it on Ubuntu 19.10, using gcc 9.2.1. Compiling that file with -O2 works for me now. Rick -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/osv-dev/eeaa07f9e101ac22a15d418ce1e591e95c652d8b.camel%40rossfell.co.uk.
