Fotis, Thanks for these patches - it makes virtiofs almost fully functional.
Regarding the d_off issue in other filesystems, I would welcome your patch to fix it. What exact symptom is caused by this incorrect implementation of d_off? Now according to this - https://man7.org/linux/man-pages/man3/readdir.3.html - d_off is not something that userspace should necessarily rely on and I am not sure how easy it will be to fix it for each other FS. Waldek On Sun, Jul 19, 2020 at 5:58 PM Fotis Xenakis <fo...@windowslive.com> wrote: > This set of patches adds readdir() support for virtio-fs: the first > patch contains minor fixes, while the second and third lay the ground > work for the fourth which actually implements the readdir functionality. > > While working on this, I noticed that the readdir implementations for > other OSv filesystems (e.g. ROFS, devfs, pseudofs) don't set the d_off > field of the dirent struct they return (this patch _does_ set it). Is > there a reason behind this pattern? If so, I will be glad to align this > implementation with the rest. > > As always, any feedback is more than welcome. > > Fotis Xenakis (4): > virtio-fs: fix allocation failure condition > virtio-fs: expose FUSE reply length > virtio-fs: use FUSE_OPENDIR and FUSE_RELEASEDIR > virtio-fs: implement readdir > > fs/virtiofs/virtiofs_dax.cc | 4 +- > fs/virtiofs/virtiofs_i.hh | 8 ++- > fs/virtiofs/virtiofs_vfsops.cc | 16 +++-- > fs/virtiofs/virtiofs_vnops.cc | 103 ++++++++++++++++++++++++++++----- > 4 files changed, 106 insertions(+), 25 deletions(-) > > -- > 2.27.0 > > -- > You received this message because you are subscribed to the Google Groups > "OSv Development" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to osv-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/osv-dev/AM0PR03MB62928C209CFA5D9AF2F1731BA67A0%40AM0PR03MB6292.eurprd03.prod.outlook.com > . > -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to osv-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/osv-dev/CAL9cFfPU_tP5p3f12YeAXz78s%3DBVRouhBXJURdXoWkoKae6HdA%40mail.gmail.com.
