These add white-box unit tests for the virtio-fs DAX window manager, exercising the manager's internal operations, using Boost.Test.
TBH, I am not too confident in these being of great value and also not particularly proud of the result elegance-wise (though this is my first time doing proper automated testing of C++ code, so my expectations might be skewed). In any case, I trust your judgement as to whether these should be merged, modified or not, and would be glad to discuss any point and address and requests. P.S. These are the test cases I had originally tested the implementation with, slightly amended. That testing had been done in isolation though, using a stubbed-out copy of the code, that's why they hadn't been included in the first place. Fotis Xenakis (2): virtio-fs: make DAX manager testable tests: add DAX manager white-box unit tests fs/virtiofs/virtiofs.hh | 9 +- fs/virtiofs/virtiofs_dax.cc | 55 +++--- fs/virtiofs/virtiofs_dax.hh | 90 ++++++--- fs/virtiofs/virtiofs_vfsops.cc | 5 +- modules/tests/Makefile | 6 +- tests/tst-dax.cc | 333 +++++++++++++++++++++++++++++++++ 6 files changed, 444 insertions(+), 54 deletions(-) create mode 100644 tests/tst-dax.cc -- 2.30.1 -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/osv-dev/VI1PR03MB3773A49BE51068C2FE644754A6959%40VI1PR03MB3773.eurprd03.prod.outlook.com.
