On Thu, 19 Jul 2012, Ian Goldberg wrote:

How's this for a proposed patch?  [Paul, I think this addresses your
"magic numbers" concern as well.]

It does, though I would have written:

+    /* Skip over the "?OTR:" */
+    otrtag += 5;
+    msglen -= 5;

        otrtag += sizeof("?OTR:")
        msglen -= sizeof("?OTR:")

Then you don't even need the comment :)

Paul
_______________________________________________
OTR-dev mailing list
[email protected]
http://lists.cypherpunks.ca/mailman/listinfo/otr-dev

Reply via email to