Hi Erik On 29/10/2008, at 3:42 AM, Erik Ljungstrom wrote: > Unless there are any objections to that solution, I'll do a proper > diff > against the .sh script rather than its product and put it in my > branch?
My main concern with this particular patch (great fast involvement btw, thanks!) is that it introduces a dependency on sed. While I think sed will generally be present on any baseline install, there are some varieties... are these sed lines generic enough to not break anywhere? And what happens if sed does not exist or chucks an error? Can this somehow be resolved without non-shell foo? I was thinking about simply double-listing each option that has a dash in it, but there may be better ways. Cheers, Arjen. -- Arjen Lentz, Director @ Open Query (http://openquery.com.au) Training and Expertise for MySQL in Australia and New Zealand OurDelta: free enhanced builds for MySQL @ http://ourdelta.org -- mysqld_safe does not honour underscores in options like mysqld does https://bugs.launchpad.net/bugs/290190 You received this bug notification because you are a member of OurDelta- developers, which is the registrant for OurDelta. Status in OurDelta - Builds for MySQL: Confirmed Bug description: mysqld accepts both dashes and underscores in server options, however mysqld_safe does not. Since it's unclear from the user's perspective (and they shouldn't NEED to know!) which options get processed only by mysqld_safe, this can mean that they use an option in the wrong way but don't notice it. Example... open_files_limit When written like that, it mysqld_safe will not recognise it and thus not call ulimit -n ... The option WILL be feed to mysqld so it shows the "correct" number in SHOW GLOBAL VARIABLES. Except, since ulimit wasn't called, it's not actually in effect! See http://bugs.mysql.com/40368 _______________________________________________ Mailing list: https://launchpad.net/~ourdelta-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~ourdelta-developers More help : https://help.launchpad.net/ListHelp
